Skip to content

Commit a93dd61

Browse files
committed
remove valid-compile run from recommended
1 parent 269717a commit a93dd61

File tree

5 files changed

+3
-6
lines changed

5 files changed

+3
-6
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ These rules relate to possible syntax or logic errors in Svelte code:
334334
| [svelte/no-unknown-style-directive-property](https://sveltejs.github.io/eslint-plugin-svelte/rules/no-unknown-style-directive-property/) | disallow unknown `style:property` | :star: |
335335
| [svelte/require-store-callbacks-use-set-param](https://sveltejs.github.io/eslint-plugin-svelte/rules/require-store-callbacks-use-set-param/) | store callbacks must use `set` param | |
336336
| [svelte/require-store-reactive-access](https://sveltejs.github.io/eslint-plugin-svelte/rules/require-store-reactive-access/) | disallow to use of the store itself as an operand. Need to use $ prefix or get function. | :star::wrench: |
337-
| [svelte/valid-compile](https://sveltejs.github.io/eslint-plugin-svelte/rules/valid-compile/) | disallow warnings when compiling. | :star: |
337+
| [svelte/valid-compile](https://sveltejs.github.io/eslint-plugin-svelte/rules/valid-compile/) | disallow warnings when compiling. | |
338338

339339
## Security Vulnerability
340340

docs/rules.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ These rules relate to possible syntax or logic errors in Svelte code:
3131
| [svelte/no-unknown-style-directive-property](./rules/no-unknown-style-directive-property.md) | disallow unknown `style:property` | :star: |
3232
| [svelte/require-store-callbacks-use-set-param](./rules/require-store-callbacks-use-set-param.md) | store callbacks must use `set` param | |
3333
| [svelte/require-store-reactive-access](./rules/require-store-reactive-access.md) | disallow to use of the store itself as an operand. Need to use $ prefix or get function. | :star::wrench: |
34-
| [svelte/valid-compile](./rules/valid-compile.md) | disallow warnings when compiling. | :star: |
34+
| [svelte/valid-compile](./rules/valid-compile.md) | disallow warnings when compiling. | |
3535

3636
## Security Vulnerability
3737

docs/rules/valid-compile.md

-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@ since: 'v0.7.0'
1010

1111
> disallow warnings when compiling.
1212
13-
- :gear: This rule is included in `"plugin:svelte/recommended"`.
14-
1513
## :book: Rule Details
1614

1715
This rule uses Svelte compiler to check the source code.

packages/eslint-plugin-svelte/src/configs/flat/recommended.ts

-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ const config: Linter.Config[] = [
4040
'svelte/require-store-reactive-access': 'error',
4141
'svelte/require-stores-init': 'error',
4242
'svelte/system': 'error',
43-
'svelte/valid-compile': 'error',
4443
'svelte/valid-each-key': 'error',
4544
'svelte/valid-prop-names-in-kit-pages': 'error'
4645
}

packages/eslint-plugin-svelte/src/rules/valid-compile.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export default createRule('valid-compile', {
3030
docs: {
3131
description: 'disallow warnings when compiling.',
3232
category: 'Possible Errors',
33-
recommended: true
33+
recommended: false
3434
},
3535
schema: [
3636
{

0 commit comments

Comments
 (0)