Merge branch 'main' of github.com:ota-meshi/eslint-plugin-svelte

marekdedic · marekdedic · commit a0e915af69a5 · 2023-03-01T11:43:26.000+01:00
diff --git a/.changeset/strong-wombats-worry.md b/.changeset/strong-wombats-worry.md
diff --git a/.changeset/tasty-houses-behave.md b/.changeset/tasty-houses-behave.md
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,25 @@
 # eslint-plugin-svelte
 
+## 2.19.1
+
+### Patch Changes
+
+- [#383](https://github.com/ota-meshi/eslint-plugin-svelte/pull/383) [`08aace5`](https://github.com/ota-meshi/eslint-plugin-svelte/commit/08aace561ab4f013b4eda47f829bc7fa545d5c9f) Thanks [@ota-meshi](https://github.com/ota-meshi)! - fix: false positives for read property in `svelte/no-dom-manipulating`
+
+## 2.19.0
+
+### Minor Changes
+
+- [#375](https://github.com/ota-meshi/eslint-plugin-svelte/pull/375) [`d692baf`](https://github.com/ota-meshi/eslint-plugin-svelte/commit/d692baf88637c8aca066d4abe62450b2b9f9940f) Thanks [@ptrxyz](https://github.com/ptrxyz)! - Change to use `parserServices.program.getCompilerOptions().target` for TS transpile in `svelte/valid-compile` rule.
+
+## 2.18.0
+
+### Minor Changes
+
+- [#368](https://github.com/ota-meshi/eslint-plugin-svelte/pull/368) [`fcb5e31`](https://github.com/ota-meshi/eslint-plugin-svelte/commit/fcb5e319620b1cc71ffe579760033813bd719410) Thanks [@marekdedic](https://github.com/marekdedic)! - feat: added the `svelte/experimental-require-slot-types` rule
+
+- [#365](https://github.com/ota-meshi/eslint-plugin-svelte/pull/365) [`e61bbc3`](https://github.com/ota-meshi/eslint-plugin-svelte/commit/e61bbc347f416f19e9e1e026c4d692e404776023) Thanks [@marekdedic](https://github.com/marekdedic)! - feat: added the `svelte/experimental-require-strict-events` rule
+
 ## 2.17.0
 
 ### Minor Changes
diff --git a/docs/rules/experimental-require-slot-types.md b/docs/rules/experimental-require-slot-types.md
@@ -3,14 +3,13 @@ pageClass: "rule-details"
 sidebarDepth: 0
 title: "svelte/experimental-require-slot-types"
 description: "require slot type declaration using the `$$Slots` interface"
+since: "v2.18.0"
 ---
 
 # svelte/experimental-require-slot-types
 
 > require slot type declaration using the `$$Slots` interface
 
-- :exclamation: <badge text="This rule has not been released yet." vertical="middle" type="error"> **_This rule has not been released yet._** </badge>
-
 ## :book: Rule Details
 
 This rule enforces the presence of the `$$Slots` interface if any slots are present in the component. This interface declares all of the used slots and their props and enables typechecking both in the component itself as well as all components that include it.
@@ -107,6 +106,10 @@ The  `$$Slots` interface is experimental and is documented in [svelte RFC #38](h
 
 Nothing.
 
+## :rocket: Version
+
+This rule was introduced in eslint-plugin-svelte v2.18.0
+
 ## :mag: Implementation
 
 - [Rule source](https://github.com/ota-meshi/eslint-plugin-svelte/blob/main/src/rules/experimental-require-slot-types.ts)
diff --git a/docs/rules/experimental-require-strict-events.md b/docs/rules/experimental-require-strict-events.md
@@ -3,14 +3,13 @@ pageClass: "rule-details"
 sidebarDepth: 0
 title: "svelte/experimental-require-strict-events"
 description: "require the strictEvents attribute on `<script>` tags"
+since: "v2.18.0"
 ---
 
 # svelte/experimental-require-strict-events
 
 > require the strictEvents attribute on `<script>` tags
 
-- :exclamation: <badge text="This rule has not been released yet." vertical="middle" type="error"> **_This rule has not been released yet._** </badge>
-
 ## :book: Rule Details
 
 This rule enforces the presence of the `strictEvents` attribute on the main `<script>` tag of all components. This attributes enforces typechecking of events dispatched by the component, e.g. making it a typescript error to listen to any non-existent events. Alternatively, the event types may be defined manually by declaring the `$$Events` interface. The `strictEvents` attribute and the `$$Events` interface are experimental and are documented in [svelte RFC #38](https://github.com/dummdidumm/rfcs/blob/ts-typedefs-within-svelte-components/text/ts-typing-props-slots-events.md#typing-events).
@@ -59,6 +58,10 @@ This rule enforces the presence of the `strictEvents` attribute on the main `<sc
 
 Nothing.
 
+## :rocket: Version
+
+This rule was introduced in eslint-plugin-svelte v2.18.0
+
 ## :mag: Implementation
 
 - [Rule source](https://github.com/ota-meshi/eslint-plugin-svelte/blob/main/src/rules/experimental-require-strict-events.ts)
diff --git a/lint-staged.config.js b/lint-staged.config.js
@@ -1,3 +1,3 @@
 "use strict"
 
-module.exports = require("@1stg/lint-staged/tsc")
+module.exports = require("@1stg/lint-staged")
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-svelte",
-  "version": "2.17.0",
+  "version": "2.19.1",
   "description": "ESLint plugin for Svelte using AST",
   "repository": "git+https://github.com/ota-meshi/eslint-plugin-svelte.git",
   "homepage": "https://ota-meshi.github.io/eslint-plugin-svelte",
@@ -69,7 +69,7 @@
     "debug": "^4.3.1",
     "eslint-utils": "^3.0.0",
     "esutils": "^2.0.3",
-    "known-css-properties": "^0.26.0",
+    "known-css-properties": "^0.27.0",
     "postcss": "^8.4.5",
     "postcss-load-config": "^3.1.4",
     "postcss-safe-parser": "^6.0.0",
@@ -140,7 +140,7 @@
     "less": "^4.1.2",
     "lint-staged": "^13.0.3",
     "locate-character": "^2.0.5",
-    "magic-string": "^0.27.0",
+    "magic-string": "^0.30.0",
     "markdown-it-anchor": "^8.4.1",
     "markdown-it-container": "^3.0.0",
     "markdown-it-emoji": "^2.0.0",
@@ -174,7 +174,7 @@
     "access": "public"
   },
   "typeCoverage": {
-    "atLeast": 99.08,
+    "atLeast": 99,
     "cache": true,
     "detail": true,
     "ignoreAsAssertion": true,
diff --git a/src/rules/no-dom-manipulating.ts b/src/rules/no-dom-manipulating.ts
@@ -78,6 +78,8 @@ export default createRule("no-dom-manipulating", {
         if (parent.left !== target || !DOM_MANIPULATING_PROPERTIES.has(name)) {
           return
         }
+      } else {
+        return
       }
       context.report({
         node: member,
diff --git a/src/shared/svelte-compile-warns/transform/typescript.ts b/src/shared/svelte-compile-warns/transform/typescript.ts
@@ -29,7 +29,10 @@ export function transform(
     const output = ts.transpileModule(code, {
       reportDiagnostics: false,
       compilerOptions: {
-        target: ts.ScriptTarget.ESNext,
+        target:
+          context.parserServices.program?.getCompilerOptions()?.target ||
+          ts.ScriptTarget.ESNext,
+        module: ts.ModuleKind.ESNext,
         importsNotUsedAsValues: ts.ImportsNotUsedAsValues.Preserve,
         sourceMap: true,
       },
diff --git a/tests/fixtures/rules/no-dom-manipulating/valid/read-prop01-input.svelte b/tests/fixtures/rules/no-dom-manipulating/valid/read-prop01-input.svelte
@@ -0,0 +1,8 @@
+<script>
+  let divElement
+  let height = ""
+
+  $: if (divElement) height = `${divElement.clientHeight}px`
+</script>
+
+<div bind:this={divElement} />
diff --git a/tests/fixtures/rules/no-dom-manipulating/valid/read-prop02-input.svelte b/tests/fixtures/rules/no-dom-manipulating/valid/read-prop02-input.svelte
@@ -0,0 +1,8 @@
+<script>
+  let divElement
+  let foo = ""
+
+  $: if (divElement) foo = `${divElement.data.foo}`
+</script>
+
+<div bind:this={divElement} data-foo="Foo" />

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`"use strict"`
`2`	`2`
`3`		`-module.exports = require("@1stg/lint-staged/tsc")`
	`3`	`+module.exports = require("@1stg/lint-staged")`
Original file line number	Diff line number	Diff line change
`@@ -78,6 +78,8 @@ export default createRule("no-dom-manipulating", {`
`78`	`78`	`if (parent.left !== target \|\| !DOM_MANIPULATING_PROPERTIES.has(name)) {`
`79`	`79`	`return`
`80`	`80`	`}`
	`81`	`+ } else {`
	`82`	`+ return`
`81`	`83`	`}`
`82`	`84`	`context.report({`
`83`	`85`	`node: member,`