fix: typescript-eslint v6 compatibility

Author: ota-meshi

.github/workflows/NodeCI.yml

@@ -77,14 +77,37 @@ jobs:
         run: |+
           pnpm rm @sveltejs/kit
           rm -rf node_modules
-      - name: Install ESLint ${{ matrix.eslint }}
+      - name: Install svelte@3
         run: |+
           pnpm install -D svelte@3
           rm -rf node_modules
       - name: Install Packages
         run: pnpm install
       - name: Test
         run: pnpm run test
+  test-for-typescript-eslint-v5:
+    name: Test for typescript-eslint v5
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest]
+        node: [18]
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+      - uses: pnpm/action-setup@v2
+      - name: Setup Node.js ${{ matrix.node }}
+        uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node }}
+      - name: Install typescript-eslint v5
+        run: |+
+          pnpm install -D @typescript-eslint/parser@5 @typescript-eslint/eslint-plugin@5
+          rm -rf node_modules
+      - name: Install Packages
+        run: pnpm install
+      - name: Test
+        run: pnpm run test
   update-resources:
     runs-on: ubuntu-latest
     steps:

package.json

@@ -77,7 +77,7 @@
     "postcss-safe-parser": "^6.0.0",
     "postcss-selector-parser": "^6.0.11",
     "semver": "^7.5.3",
-    "svelte-eslint-parser": "^0.32.0"
+    "svelte-eslint-parser": "^0.32.2"
   },
   "devDependencies": {
     "@1stg/browserslist-config": "^1.2.3",
@@ -159,7 +159,7 @@
     "prism-svelte": "^0.5.0",
     "prismjs": "^1.25.0",
     "rimraf": "^5.0.0",
-    "sass": "^1.51.0",
+    "sass": "^1.64.0",
     "simple-git-hooks": "^2.8.0",
     "source-map-js": "^1.0.2",
     "stylelint": "^15.0.0",

src/rules/indent-helpers/ts.ts

@@ -33,7 +33,7 @@ export function defineVisitor(context: IndentContext): NodeListener {
         count: 2,
         includeComments: false,
       })
-      const baseToken = sourceCode.getFirstToken(node.parent!)
+      const baseToken = sourceCode.getFirstToken(node.parent)
       offsets.setOffsetToken([colonOrArrowToken, secondToken], 1, baseToken)
 
       const before = sourceCode.getTokenBefore(colonOrArrowToken)
@@ -636,7 +636,7 @@ export function defineVisitor(context: IndentContext): NodeListener {
       if (firstToken.type === "Punctuator") {
         // method
         leftParenToken = firstToken
-        bodyBaseToken = sourceCode.getFirstToken(node.parent!)
+        bodyBaseToken = sourceCode.getFirstToken(node.parent)
       } else {
         let nextToken = sourceCode.getTokenAfter(firstToken)
         let nextTokenOffset = 0
@@ -823,12 +823,16 @@ export function defineVisitor(context: IndentContext): NodeListener {
         includeComments: false,
       })!
       offsets.setOffsetToken(leftParenToken, 1, firstToken)
-      const rightParenToken = sourceCode.getTokenAfter(node.parameter, {
+      const argument =
+        node.argument ||
+        // eslint-disable-next-line @typescript-eslint/no-explicit-any -- typescript-eslint<v6 node
+        (node as any).parameter
+      const rightParenToken = sourceCode.getTokenAfter(argument, {
         filter: isClosingParenToken,
         includeComments: false,
       })!
       offsets.setOffsetElementList(
-        [node.parameter],
+        [argument],
         leftParenToken,
         rightParenToken,
         1,
@@ -954,7 +958,7 @@ export function defineVisitor(context: IndentContext): NodeListener {
       })
       offsets.setOffsetToken(secondToken, 0, atToken)
 
-      const parent = node.parent!
+      const parent = node.parent
       const { decorators } = parent as { decorators?: TSESTree.Decorator[] }
       if (!decorators || decorators.length === 0) {
         return

tests/fixtures/rules/indent/invalid/ts/ts-interface01-errors.yaml

@@ -74,15 +74,15 @@
   line: 21
   column: 1
   suggestions: null
-- message: Expected indentation of 6 spaces but found 0 spaces.
+- message: Expected indentation of 4 spaces but found 0 spaces.
   line: 22
   column: 1
   suggestions: null
 - message: Expected indentation of 6 spaces but found 0 spaces.
   line: 23
   column: 1
   suggestions: null
-- message: Expected indentation of 4 spaces but found 0 spaces.
+- message: Expected indentation of 6 spaces but found 0 spaces.
   line: 24
   column: 1
   suggestions: null

tests/fixtures/rules/indent/invalid/ts/ts-interface01-input.svelte

@@ -17,12 +17,12 @@ string
 }
 class
 Impl
+extends
+E
 implements
 I2
 ,
 I
-extends
-E
 {
 public foo
 =

tests/fixtures/rules/indent/invalid/ts/ts-interface01-output.svelte

@@ -17,12 +17,12 @@
   }
   class
     Impl
+    extends
+      E
     implements
       I2
       ,
       I
-    extends
-      E
   {
     public foo
       =

tests/fixtures/rules/indent/invalid/ts/ts-interface03-errors.yaml

@@ -14,6 +14,26 @@
   line: 6
   column: 1
   suggestions: null
+- message: Expected indentation of 4 spaces but found 0 spaces.
+  line: 7
+  column: 1
+  suggestions: null
+- message: Expected indentation of 6 spaces but found 0 spaces.
+  line: 8
+  column: 1
+  suggestions: null
+- message: Expected indentation of 8 spaces but found 0 spaces.
+  line: 9
+  column: 1
+  suggestions: null
+- message: Expected indentation of 10 spaces but found 0 spaces.
+  line: 10
+  column: 1
+  suggestions: null
+- message: Expected indentation of 8 spaces but found 0 spaces.
+  line: 11
+  column: 1
+  suggestions: null
 - message: Expected indentation of 2 spaces but found 0 spaces.
   line: 12
   column: 1

tests/fixtures/rules/indent/invalid/ts/ts-interface03-input.svelte

@@ -4,7 +4,7 @@ interface Foo
 <
 T
 >
-implements // visitor key is not provided
+extends
 Bar
 <
 T

tests/fixtures/rules/indent/invalid/ts/ts-interface03-output.svelte

@@ -4,11 +4,11 @@
     <
       T
     >
-implements // visitor key is not provided
-Bar
-<
-T
->
+    extends
+      Bar
+        <
+          T
+        >
   { }
 </script>
 

tests/src/rules/@typescript-eslint/original-tests/RuleTester.ts

@@ -1,30 +1,51 @@
 // Original test cases
 // https://github.com/typescript-eslint/typescript-eslint/blob/78467fc1bde9bd2db1e08b3d19f151f4adaff8a9/packages/eslint-plugin/tests/rules/no-unnecessary-condition.test.ts
 /* eslint func-style: off, eslint-plugin/consistent-output: off -- respect original  */
-import type {
-  InvalidTestCase,
-  TestCaseError,
-} from "@typescript-eslint/utils/dist/ts-eslint"
 import * as path from "path"
+import { RuleTester } from "eslint"
 
 import rule from "../../../../../src/rules/@typescript-eslint/no-unnecessary-condition"
-import { getFixturesRootDir, noFormat, RuleTester } from "./RuleTester"
+
+function getFixturesRootDir(): string {
+  return path.join(__dirname, "fixtures")
+}
 
 const rootPath = getFixturesRootDir()
 
 const ruleTester = new RuleTester({
-  parser: "@typescript-eslint/parser",
+  parser: require.resolve("@typescript-eslint/parser"),
   parserOptions: {
     tsconfigRootDir: rootPath,
     project: "./tsconfig.json",
   },
 })
 
+function withFileName<
+  TestCase extends RuleTester.ValidTestCase | RuleTester.InvalidTestCase,
+>(list: (string | TestCase)[]): TestCase[] {
+  return list.map((e) => {
+    if (typeof e === "string") {
+      return { code: e, filename: path.join(rootPath, "file.ts") } as TestCase
+    }
+    if (e.filename) return e
+    return {
+      ...e,
+      filename: e.parserOptions?.tsconfigRootDir
+        ? path.join(e.parserOptions.tsconfigRootDir, "file.ts")
+        : path.join(rootPath, "file.ts"),
+    } as TestCase
+  })
+}
+
 const ruleError = (
   line: number,
   column: number,
   messageId: string,
-): TestCaseError<string> => ({
+): {
+  messageId: string
+  line: number
+  column: number
+} => ({
   messageId,
   line,
   column,
@@ -39,13 +60,13 @@ const t1 = b1 && b2;
 const unnecessaryConditionTest = (
   condition: string,
   messageId: string,
-): InvalidTestCase<string, any> => ({
+): RuleTester.InvalidTestCase => ({
   code: necessaryConditionTest(condition),
   errors: [ruleError(4, 12, messageId)],
 })
 
 ruleTester.run("no-unnecessary-conditionals", rule as any, {
-  valid: [
+  valid: withFileName([
     `
 declare const b1: boolean;
 declare const b2: boolean;
@@ -519,8 +540,8 @@ if (x) {
         tsconfigRootDir: path.join(rootPath, "unstrict"),
       },
     },
-  ],
-  invalid: [
+  ]),
+  invalid: withFileName([
     // Ensure that it's checking in all the right places
     {
       code: `
@@ -904,7 +925,7 @@ do {} while (true);
       ],
     },
     {
-      code: noFormat`
+      code: `
 let foo = { bar: true };
 foo?.bar;
 foo ?. bar;
@@ -954,7 +975,7 @@ foo
       ],
     },
     {
-      code: noFormat`
+      code: `
 let foo = () => {};
 foo?.();
 foo ?. ();
@@ -1004,7 +1025,7 @@ foo
       ],
     },
     {
-      code: noFormat`
+      code: `
 let foo = () => {};
 foo?.(bar);
 foo ?. (bar);
@@ -1540,5 +1561,5 @@ if (x) {
         },
       ],
     },
-  ],
+  ]),
 })

tests/src/rules/@typescript-eslint/original-tests/no-unnecessary-condition.ts

@@ -1,5 +1,4 @@
 import { RuleTester } from "eslint"
-import path from "path"
 import rule from "../../../src/rules/indent"
 import { loadTestCases } from "../../utils/utils"
 
@@ -15,35 +14,3 @@ const tester = new RuleTester({
 })
 
 tester.run("indent", rule as any, loadTestCases("indent"))
-
-const testerForTsParserV4 = new RuleTester({
-  parserOptions: {
-    ecmaVersion: 2020,
-    sourceType: "module",
-    parser: {
-      ts: "@typescript-eslint/parser-v4",
-      js: "espree",
-    },
-  },
-})
-
-describe("use @typescript-eslint/parser@4", () => {
-  testerForTsParserV4.run(
-    "indent",
-    rule as any,
-    loadTestCases("indent", {
-      filter(filename) {
-        if (
-          filename.endsWith("ts-class03-input.svelte") ||
-          filename.endsWith("ts-decorator01-input.svelte") ||
-          filename.endsWith("ts-decorator02-input.svelte")
-        ) {
-          // Decorator nodes in ts4.8 are incompatible.
-          return false
-        }
-
-        return path.basename(path.dirname(filename)) === "ts"
-      },
-    }),
-  )
-})