chore: refactor test

Author: baseballyama

src/rules/infinite-reactive-loop.ts

@@ -118,7 +118,7 @@ function isReactiveVariableNode(
 
     return resolved.defs.some((def) => {
       return (
-        (def as any).parent?.parent!.type === "SvelteScriptElement" &&
+        (def as any).parent?.parent?.type === "SvelteScriptElement" &&
         def.name.type === "Identifier" &&
         def.name.name === node.name
       )

tests/fixtures/rules/infinite-reactive-loop/invalid/test14-errors.yaml renamed to tests/fixtures/rules/infinite-reactive-loop/invalid/await/test01-errors.yaml

@@ -1,4 +1,4 @@
 - message: Possibly it may occur an infinite reactive loop.
-  line: 12
+  line: 7
   column: 5
   suggestions: null

tests/fixtures/rules/infinite-reactive-loop/invalid/await/test01-input.svelte

@@ -0,0 +1,9 @@
+<script>
+  let a = 0
+
+  $: (async () => {
+    a = a + 1
+    await doSomething()
+    a = a + 1
+  })()
+</script>

tests/fixtures/rules/infinite-reactive-loop/invalid/test07-errors.yaml renamed to tests/fixtures/rules/infinite-reactive-loop/invalid/function-call/test01-errors.yaml

@@ -13,4 +13,9 @@
     console.log(a)
     await doSomething()
   })()
+
+  $: (async () => {
+    // should not report here
+    await doSomething()
+  })()
 </script>

tests/fixtures/rules/infinite-reactive-loop/invalid/test07-input.svelte renamed to tests/fixtures/rules/infinite-reactive-loop/invalid/function-call/test01-input.svelte

@@ -12,4 +12,9 @@
     console.log(a)
     await doSomething()
   })()
+
+  $: (async () => {
+    // should not report here
+    await doSomething()
+  })()
 </script>

tests/fixtures/rules/infinite-reactive-loop/invalid/test04-errors.yaml renamed to tests/fixtures/rules/infinite-reactive-loop/invalid/function-call/test02-errors.yaml

@@ -17,4 +17,10 @@
     await doSomething()
     doSomething2()
   })()
+
+  $: (async () => {
+    // should not report here
+    await doSomething()
+    doSomething2()
+  })()
 </script>

tests/fixtures/rules/infinite-reactive-loop/invalid/test04-input.svelte renamed to tests/fixtures/rules/infinite-reactive-loop/invalid/function-call/test02-input.svelte

@@ -10,4 +10,10 @@
     await fetch()
     doSomething()
   })()
+
+  $: (async () => {
+    // should not report here
+    await fetch()
+    doSomething()
+  })()
 </script>

tests/fixtures/rules/infinite-reactive-loop/invalid/test05-errors.yaml renamed to tests/fixtures/rules/infinite-reactive-loop/invalid/function-call/test03-errors.yaml

@@ -1,5 +1,5 @@
 - message: Possibly it may occur an infinite reactive loop.
-  line: 7
+  line: 6
   column: 5
   suggestions: null
 - message: Possibly it may occur an infinite reactive loop because this function may update `foo`.

tests/fixtures/rules/infinite-reactive-loop/invalid/test05-input.svelte renamed to tests/fixtures/rules/infinite-reactive-loop/invalid/function-call/test03-input.svelte

@@ -1,5 +1,4 @@
 <script>
-  let obj = { a: 0 }
   let foo = { obj: 1 }
 
   const doSomething = async () => {
@@ -8,8 +7,10 @@
   }
 
   $: (async () => {
+    const obj = { a: 0 }
     console.log(obj)
     await doSomething()
     foo.obj += 1
+    obj.a = 1
   })()
 </script>

tests/fixtures/rules/infinite-reactive-loop/invalid/test08-errors.yaml renamed to tests/fixtures/rules/infinite-reactive-loop/invalid/function-call/test04-errors.yaml

@@ -0,0 +1,4 @@
+- message: Possibly it may occur an infinite reactive loop.
+  line: 9
+  column: 30
+  suggestions: null

tests/fixtures/rules/infinite-reactive-loop/invalid/test08-input.svelte renamed to tests/fixtures/rules/infinite-reactive-loop/invalid/function-call/test04-input.svelte

@@ -0,0 +1,11 @@
+<script>
+  let obj = { a: 0 }
+
+  const doSomething = (a, b) => {
+    console.log({ a, b })
+  }
+
+  $: (async () => {
+    doSomething((await "a", (obj.a += 1)))
+  })()
+</script>

tests/fixtures/rules/infinite-reactive-loop/invalid/test10-errors.yaml renamed to tests/fixtures/rules/infinite-reactive-loop/invalid/function-call/test05-errors.yaml

@@ -1,12 +1,12 @@
 - message: Possibly it may occur an infinite reactive loop.
-  line: 7
+  line: 6
   column: 7
   suggestions: null
 - message: Possibly it may occur an infinite reactive loop.
-  line: 10
+  line: 7
   column: 7
   suggestions: null
 - message: Possibly it may occur an infinite reactive loop.
-  line: 13
+  line: 11
   column: 7
   suggestions: null

tests/fixtures/rules/infinite-reactive-loop/invalid/test10-input.svelte renamed to tests/fixtures/rules/infinite-reactive-loop/invalid/function-call/test05-input.svelte

@@ -0,0 +1,14 @@
+<script>
+  let a = 0
+
+  $: (() => {
+    Promise.resolve().then(() => {
+      a = a + 1
+      a += 1
+    })
+
+    Promise.resolve().catch(() => {
+      a = a + 1
+    })
+  })()
+</script>

tests/fixtures/rules/infinite-reactive-loop/invalid/test11-errors.yaml renamed to tests/fixtures/rules/infinite-reactive-loop/invalid/function-call/test06-errors.yaml

@@ -0,0 +1,8 @@
+- message: Possibly it may occur an infinite reactive loop.
+  line: 10
+  column: 9
+  suggestions: null
+- message: Possibly it may occur an infinite reactive loop.
+  line: 13
+  column: 9
+  suggestions: null

tests/fixtures/rules/infinite-reactive-loop/invalid/test11-input.svelte renamed to tests/fixtures/rules/infinite-reactive-loop/invalid/function-call/test06-input.svelte

@@ -0,0 +1,17 @@
+<script>
+  let a = 0
+
+  $: {
+    a = a + 1
+    new Promise((resolve, reject) => {
+      /** do something */
+    })
+      .then(() => {
+        a = a + 1
+      })
+      .catch(() => {
+        a = a + 1
+      })
+    a = a + 1
+  }
+</script>

tests/fixtures/rules/infinite-reactive-loop/invalid/test13-errors.yaml renamed to tests/fixtures/rules/infinite-reactive-loop/invalid/function-call/test07-errors.yaml

@@ -0,0 +1,8 @@
+- message: Possibly it may occur an infinite reactive loop.
+  line: 8
+  column: 9
+  suggestions: null
+- message: Possibly it may occur an infinite reactive loop.
+  line: 11
+  column: 9
+  suggestions: null

tests/fixtures/rules/infinite-reactive-loop/invalid/test13-input.svelte renamed to tests/fixtures/rules/infinite-reactive-loop/invalid/function-call/test07-input.svelte

@@ -0,0 +1,15 @@
+<script>
+  let a = 0
+
+  $: (() => {
+    a = a + 1
+    Promise.all([])
+      .then(() => {
+        a = a + 1
+      })
+      .catch(() => {
+        a = a + 1
+      })
+    a = a + 1
+  })()
+</script>

tests/fixtures/rules/infinite-reactive-loop/invalid/test15-errors.yaml renamed to tests/fixtures/rules/infinite-reactive-loop/invalid/function-call/test08-errors.yaml

@@ -0,0 +1,4 @@
+- message: Possibly it may occur an infinite reactive loop.
+  line: 7
+  column: 5
+  suggestions: null

tests/fixtures/rules/infinite-reactive-loop/invalid/test15-input.svelte renamed to tests/fixtures/rules/infinite-reactive-loop/invalid/function-call/test08-input.svelte

@@ -0,0 +1,9 @@
+<script>
+  let a = 0
+
+  $: (async () => {
+    a = a + 1
+    await Promise.resolve()
+    a = a + 1
+  })()
+</script>

tests/fixtures/rules/infinite-reactive-loop/invalid/test16-errors.yaml renamed to tests/fixtures/rules/infinite-reactive-loop/invalid/function-call/test09-errors.yaml

@@ -0,0 +1,8 @@
+- message: Possibly it may occur an infinite reactive loop.
+  line: 7
+  column: 9
+  suggestions: null
+- message: Possibly it may occur an infinite reactive loop.
+  line: 10
+  column: 9
+  suggestions: null

tests/fixtures/rules/infinite-reactive-loop/invalid/test16-input.svelte renamed to tests/fixtures/rules/infinite-reactive-loop/invalid/function-call/test09-input.svelte

@@ -0,0 +1,13 @@
+<script>
+  let a = 0
+
+  $: (() => {
+    Promise.resolve()
+      .catch(() => {
+        a = a + 1
+      })
+      .catch(() => {
+        a = a + 1
+      })
+  })()
+</script>

tests/fixtures/rules/infinite-reactive-loop/invalid/function-call/test10-errors.yaml

@@ -1,8 +1,8 @@
 - message: Possibly it may occur an infinite reactive loop.
-  line: 12
-  column: 24
+  line: 7
+  column: 9
   suggestions: null
 - message: Possibly it may occur an infinite reactive loop.
-  line: 13
-  column: 25
+  line: 10
+  column: 9
   suggestions: null

tests/fixtures/rules/infinite-reactive-loop/invalid/function-call/test10-input.svelte

@@ -0,0 +1,13 @@
+<script>
+  let a = 0
+
+  $: (() => {
+    Promise.resolve()
+      .catch(() => {
+        a = a + 1
+      })
+      .then(() => {
+        a = a + 1
+      })
+  })()
+</script>

tests/fixtures/rules/infinite-reactive-loop/invalid/test09-errors.yaml renamed to tests/fixtures/rules/infinite-reactive-loop/invalid/promise/test01-errors.yaml

@@ -0,0 +1,8 @@
+- message: Possibly it may occur an infinite reactive loop.
+  line: 7
+  column: 7
+  suggestions: null
+- message: Possibly it may occur an infinite reactive loop.
+  line: 13
+  column: 7
+  suggestions: null

tests/fixtures/rules/infinite-reactive-loop/invalid/promise/test01-input.svelte

@@ -0,0 +1,16 @@
+<script>
+  const queueMicrotask2 = queueMicrotask
+  let a = 0
+
+  $: {
+    queueMicrotask(() => {
+      a = a + 1
+    })
+  }
+
+  $: {
+    queueMicrotask2(() => {
+      a = a + 1
+    })
+  }
+</script>

tests/fixtures/rules/infinite-reactive-loop/invalid/promise/test02-errors.yaml

@@ -0,0 +1,8 @@
+- message: Possibly it may occur an infinite reactive loop.
+  line: 7
+  column: 7
+  suggestions: null
+- message: Possibly it may occur an infinite reactive loop.
+  line: 13
+  column: 7
+  suggestions: null

tests/fixtures/rules/infinite-reactive-loop/invalid/promise/test02-input.svelte

@@ -0,0 +1,16 @@
+<script>
+  const setInterval2 = setInterval
+  let a = 0
+
+  $: {
+    setInterval(() => {
+      a = a + 1
+    })
+  }
+
+  $: {
+    setInterval2(() => {
+      a = a + 1
+    })
+  }
+</script>

tests/fixtures/rules/infinite-reactive-loop/invalid/promise/test03-errors.yaml

@@ -0,0 +1,8 @@
+- message: Possibly it may occur an infinite reactive loop.
+  line: 11
+  column: 7
+  suggestions: null
+- message: Possibly it may occur an infinite reactive loop.
+  line: 17
+  column: 7
+  suggestions: null

tests/fixtures/rules/infinite-reactive-loop/invalid/promise/test03-input.svelte

@@ -0,0 +1,24 @@
+<script>
+  const setTimeout2 = setTimeout
+  let a = 0
+
+  function doSomething(fn) {
+    fn()
+  }
+
+  $: {
+    setTimeout(() => {
+      a = a + 1
+    })
+  }
+
+  $: {
+    setTimeout2(() => {
+      a = a + 1
+    })
+
+    doSomething(() => {
+      a = a + 1
+    })
+  }
+</script>