fix: use ReferenceTracker

Author: baseballyama

src/rules/no-store-async.ts

@@ -1,5 +1,5 @@
 import { createRule } from "../utils"
-import type * as ESTree from "estree"
+import { extractStoreReferences } from "./reference-helpers/svelte-store"
 
 export default createRule("no-store-async", {
   meta: {
@@ -18,26 +18,24 @@ export default createRule("no-store-async", {
   },
   create(context) {
     return {
-      CallExpression(node: ESTree.CallExpression) {
-        if (node.callee.type !== "Identifier") return
-        const { name } = node.callee
-        if (name !== "writable" && name !== "readable" && name !== "derived")
-          return
-        const [, fn] = node.arguments
-        if (fn.type !== "ArrowFunctionExpression" || !fn.async) return
+      Program() {
+        for (const { node } of extractStoreReferences(context)) {
+          const [, fn] = node.arguments
+          if (fn.type !== "ArrowFunctionExpression" || !fn.async) continue
 
-        const start = fn.loc?.start ?? { line: 1, column: 0 }
-        context.report({
-          node: fn,
-          loc: {
-            start,
-            end: {
-              line: start.line,
-              column: start.column + 5,
+          const start = fn.loc?.start ?? { line: 1, column: 0 }
+          context.report({
+            node: fn,
+            loc: {
+              start,
+              end: {
+                line: start.line,
+                column: start.column + 5,
+              },
             },
-          },
-          messageId: "unexpected",
-        })
+            messageId: "unexpected",
+          })
+        }
       },
     }
   },

src/rules/reference-helpers/svelte-store.ts

@@ -0,0 +1,29 @@
+import type * as ESTree from "estree"
+import { ReferenceTracker } from "eslint-utils"
+import type { RuleContext } from "../../types"
+
+/** Extract 'svelte/store' references */
+export function* extractStoreReferences(
+  context: RuleContext,
+): Generator<{ node: ESTree.CallExpression; name: string }, void> {
+  const referenceTracker = new ReferenceTracker(context.getScope())
+  for (const { node, path } of referenceTracker.iterateEsmReferences({
+    "svelte/store": {
+      [ReferenceTracker.ESM]: true,
+      writable: {
+        [ReferenceTracker.CALL]: true,
+      },
+      readable: {
+        [ReferenceTracker.CALL]: true,
+      },
+      derived: {
+        [ReferenceTracker.CALL]: true,
+      },
+    },
+  })) {
+    yield {
+      node: node as ESTree.CallExpression,
+      name: path[path.length - 1],
+    }
+  }
+}

src/rules/require-stores-init.ts

@@ -1,6 +1,5 @@
 import { createRule } from "../utils"
-import type * as ESTree from "estree"
-import { ReferenceTracker } from "eslint-utils"
+import { extractStoreReferences } from "./reference-helpers/svelte-store"
 
 export default createRule("require-stores-init", {
   meta: {
@@ -16,33 +15,9 @@ export default createRule("require-stores-init", {
     type: "suggestion",
   },
   create(context) {
-    /** Extract 'svelte/store' references */
-    function* extractStoreReferences() {
-      const referenceTracker = new ReferenceTracker(context.getScope())
-      for (const { node, path } of referenceTracker.iterateEsmReferences({
-        "svelte/store": {
-          [ReferenceTracker.ESM]: true,
-          writable: {
-            [ReferenceTracker.CALL]: true,
-          },
-          readable: {
-            [ReferenceTracker.CALL]: true,
-          },
-          derived: {
-            [ReferenceTracker.CALL]: true,
-          },
-        },
-      })) {
-        yield {
-          node: node as ESTree.CallExpression,
-          name: path[path.length - 1],
-        }
-      }
-    }
-
     return {
       Program() {
-        for (const { node, name } of extractStoreReferences()) {
+        for (const { node, name } of extractStoreReferences(context)) {
           const minArgs =
             name === "writable" || name === "readable"
               ? 1

tests/fixtures/rules/no-store-async/invalid/test02-errors.yaml

@@ -0,0 +1,12 @@
+- message: Do not pass async functions to svelte stores.
+  line: 3
+  column: 35
+  suggestions: null
+- message: Do not pass async functions to svelte stores.
+  line: 6
+  column: 35
+  suggestions: null
+- message: Do not pass async functions to svelte stores.
+  line: 9
+  column: 31
+  suggestions: null

tests/fixtures/rules/no-store-async/invalid/test02-input.js

@@ -0,0 +1,11 @@
+import * as stores from "svelte/store"
+
+const w2 = stores.writable(false, async () => {
+  /** do nothing */
+})
+const r2 = stores.readable(false, async () => {
+  /** do nothing */
+})
+const d2 = stores.derived(a1, async ($a1) => {
+  /** do nothing */
+})

tests/fixtures/rules/no-store-async/invalid/test03-errors.yaml

@@ -0,0 +1,12 @@
+- message: Do not pass async functions to svelte stores.
+  line: 3
+  column: 21
+  suggestions: null
+- message: Do not pass async functions to svelte stores.
+  line: 6
+  column: 21
+  suggestions: null
+- message: Do not pass async functions to svelte stores.
+  line: 9
+  column: 18
+  suggestions: null

tests/fixtures/rules/no-store-async/invalid/test03-input.js

@@ -0,0 +1,11 @@
+import { writable as A, readable as B, derived as C } from "svelte/store"
+
+const w2 = A(false, async () => {
+  /** do nothing */
+})
+const r2 = B(false, async () => {
+  /** do nothing */
+})
+const d2 = C(a1, async ($a1) => {
+  /** do nothing */
+})