Skip to content

Commit 336dfa1

Browse files
committed
chore: remove duplicate code
1 parent 1eab26b commit 336dfa1

File tree

2 files changed

+7
-22
lines changed

2 files changed

+7
-22
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@
174174
"access": "public"
175175
},
176176
"typeCoverage": {
177-
"atLeast": 99.06,
177+
"atLeast": 99.08,
178178
"cache": true,
179179
"detail": true,
180180
"ignoreAsAssertion": true,

src/rules/infinite-reactive-loop.ts

+6-21
Original file line numberDiff line numberDiff line change
@@ -272,10 +272,13 @@ function doLint(
272272
) {
273273
let isSameMicroTask = pIsSameTask
274274

275+
const differentMicroTaskEnterNodes: TSESTree.Node[] = []
276+
275277
traverseNodes(ast, {
276278
enterNode(node) {
277279
// Promise.then() or Promise.catch() is called.
278280
if (isPromiseThenOrCatchBody(node)) {
281+
differentMicroTaskEnterNodes.push(node)
279282
isSameMicroTask = false
280283
}
281284

@@ -285,6 +288,7 @@ function doLint(
285288
...taskReferences,
286289
]) {
287290
if (isChildNode(callExpression, node)) {
291+
differentMicroTaskEnterNodes.push(node)
288292
isSameMicroTask = false
289293
}
290294
}
@@ -295,6 +299,7 @@ function doLint(
295299
node.parent?.right.type === "AwaitExpression" &&
296300
node.parent?.left === node
297301
) {
302+
differentMicroTaskEnterNodes.push(node)
298303
isSameMicroTask = false
299304
}
300305

@@ -355,27 +360,7 @@ function doLint(
355360
}
356361
}
357362

358-
// Promise.then() or Promise.catch() is called.
359-
if (isPromiseThenOrCatchBody(node)) {
360-
isSameMicroTask = true
361-
}
362-
363-
// `tick`, `setTimeout`, `setInterval` , `queueMicrotask` is called
364-
for (const { node: callExpression } of [
365-
...tickCallExpressions,
366-
...taskReferences,
367-
]) {
368-
if (isChildNode(callExpression, node)) {
369-
isSameMicroTask = true
370-
}
371-
}
372-
373-
// left side of await block
374-
if (
375-
node.parent?.type === "AssignmentExpression" &&
376-
node.parent?.right.type === "AwaitExpression" &&
377-
node.parent?.left === node
378-
) {
363+
if (differentMicroTaskEnterNodes.includes(node)) {
379364
isSameMicroTask = true
380365
}
381366
},

0 commit comments

Comments
 (0)