fix: false positives for read property in svelte/no-dom-manipulating (#383)

Author: ota-meshi

.changeset/grumpy-gifts-repeat.md

@@ -0,0 +1,5 @@
+---
+"eslint-plugin-svelte": patch
+---
+
+fix: false positives for read property in `svelte/no-dom-manipulating`

src/rules/no-dom-manipulating.ts

@@ -78,6 +78,8 @@ export default createRule("no-dom-manipulating", {
         if (parent.left !== target || !DOM_MANIPULATING_PROPERTIES.has(name)) {
           return
         }
+      } else {
+        return
       }
       context.report({
         node: member,

tests/fixtures/rules/no-dom-manipulating/valid/read-prop01-input.svelte

@@ -0,0 +1,8 @@
+<script>
+  let divElement
+  let height = ""
+
+  $: if (divElement) height = `${divElement.clientHeight}px`
+</script>
+
+<div bind:this={divElement} />

tests/fixtures/rules/no-dom-manipulating/valid/read-prop02-input.svelte

@@ -0,0 +1,8 @@
+<script>
+  let divElement
+  let foo = ""
+
+  $: if (divElement) foo = `${divElement.data.foo}`
+</script>
+
+<div bind:this={divElement} data-foo="Foo" />