chore: minor refactor

Author: ota-meshi

.changeset/witty-donuts-jog.md

@@ -2,4 +2,4 @@
 "eslint-plugin-svelte": minor
 ---
 
-Added the require-event-dispatcher-types rule
+feat: added the `svelte/require-event-dispatcher-types` rule

README.md

@@ -336,7 +336,7 @@ These rules relate to better ways of doing things to help you avoid problems:
 | [svelte/no-unused-svelte-ignore](https://ota-meshi.github.io/eslint-plugin-svelte/rules/no-unused-svelte-ignore/) | disallow unused svelte-ignore comments | :star: |
 | [svelte/no-useless-mustaches](https://ota-meshi.github.io/eslint-plugin-svelte/rules/no-useless-mustaches/) | disallow unnecessary mustache interpolations | :wrench: |
 | [svelte/prefer-destructured-store-props](https://ota-meshi.github.io/eslint-plugin-svelte/rules/prefer-destructured-store-props/) | destructure values from object stores for better change tracking & fewer redraws | :bulb: |
-| [svelte/require-event-dispatcher-types](https://ota-meshi.github.io/eslint-plugin-svelte/rules/require-event-dispatcher-types/) | require type parameters for createEventDispatcher |  |
+| [svelte/require-event-dispatcher-types](https://ota-meshi.github.io/eslint-plugin-svelte/rules/require-event-dispatcher-types/) | require type parameters for `createEventDispatcher` |  |
 | [svelte/require-optimized-style-attribute](https://ota-meshi.github.io/eslint-plugin-svelte/rules/require-optimized-style-attribute/) | require style attributes that can be optimized |  |
 | [svelte/require-stores-init](https://ota-meshi.github.io/eslint-plugin-svelte/rules/require-stores-init/) | require initial value in store |  |
 

docs/rules.md

@@ -55,7 +55,7 @@ These rules relate to better ways of doing things to help you avoid problems:
 | [svelte/no-unused-svelte-ignore](./rules/no-unused-svelte-ignore.md) | disallow unused svelte-ignore comments | :star: |
 | [svelte/no-useless-mustaches](./rules/no-useless-mustaches.md) | disallow unnecessary mustache interpolations | :wrench: |
 | [svelte/prefer-destructured-store-props](./rules/prefer-destructured-store-props.md) | destructure values from object stores for better change tracking & fewer redraws | :bulb: |
-| [svelte/require-event-dispatcher-types](./rules/require-event-dispatcher-types.md) | require type parameters for createEventDispatcher |  |
+| [svelte/require-event-dispatcher-types](./rules/require-event-dispatcher-types.md) | require type parameters for `createEventDispatcher` |  |
 | [svelte/require-optimized-style-attribute](./rules/require-optimized-style-attribute.md) | require style attributes that can be optimized |  |
 | [svelte/require-stores-init](./rules/require-stores-init.md) | require initial value in store |  |
 

docs/rules/require-event-dispatcher-types.md

@@ -2,18 +2,20 @@
 pageClass: "rule-details"
 sidebarDepth: 0
 title: "svelte/require-event-dispatcher-types"
-description: "require type parameters for createEventDispatcher"
+description: "require type parameters for `createEventDispatcher`"
 ---
 
 # svelte/require-event-dispatcher-types
 
-> require type parameters for createEventDispatcher
+> require type parameters for `createEventDispatcher`
+
+- :exclamation: <badge text="This rule has not been released yet." vertical="middle" type="error"> **_This rule has not been released yet._** </badge>
 
 ## :book: Rule Details
 
-This rule is aimed to enforce type parameters when calling `createEventDispatcher`. Adding types makes all `dispatch` calls as well as all event listeners typechecked. For more information, see the [svelte docs](https://github.com/sveltejs/language-tools/blob/master/docs/preprocessors/typescript.md#typing-component-events). 
+This rule is aimed to enforce type parameters when calling `createEventDispatcher`. Adding types makes all `dispatch` calls as well as all event listeners typechecked. For more information, see the [svelte docs](https://github.com/sveltejs/language-tools/blob/master/docs/preprocessors/typescript.md#typing-component-events).
 
-<ESLintCodeBlock language="javascript">
+<ESLintCodeBlock>
 
 <!--eslint-skip-->
 
@@ -40,10 +42,6 @@ This rule is aimed to enforce type parameters when calling `createEventDispatche
 
 Nothing.
 
-## :rocket: Version
-
-This rule was introduced in eslint-plugin-svelte v2.16.0
-
 ## :mag: Implementation
 
 - [Rule source](https://github.com/ota-meshi/eslint-plugin-svelte/blob/main/src/rules/require-event-dispatcher-types.ts)

src/rules/reference-helpers/svelte-createEventDispatcher.ts

@@ -1,17 +1,18 @@
+import { ReferenceTracker } from "eslint-utils"
 import { createRule } from "../utils"
 import { getLangValue } from "../utils/ast-utils"
-import { extractCreateEventDispatcherReferences } from "./reference-helpers/svelte-createEventDispatcher"
+import type { TSESTree } from "@typescript-eslint/types"
 
 export default createRule("require-event-dispatcher-types", {
   meta: {
     docs: {
-      description: "require type parameters for createEventDispatcher",
+      description: "require type parameters for `createEventDispatcher`",
       category: "Best Practices",
       recommended: false,
     },
     schema: [],
     messages: {
-      missingTypeParameter: `Type parameters missing for the createEventDispatcher function call.`,
+      missingTypeParameter: `Type parameters missing for the \`createEventDispatcher\` function call.`,
     },
     type: "suggestion",
   },
@@ -28,7 +29,16 @@ export default createRule("require-event-dispatcher-types", {
         if (!isTs) {
           return
         }
-        for (const node of extractCreateEventDispatcherReferences(context)) {
+        const referenceTracker = new ReferenceTracker(context.getScope())
+        for (const { node: n } of referenceTracker.iterateEsmReferences({
+          svelte: {
+            [ReferenceTracker.ESM]: true,
+            createEventDispatcher: {
+              [ReferenceTracker.CALL]: true,
+            },
+          },
+        })) {
+          const node = n as TSESTree.CallExpression
           if (node.typeParameters === undefined) {
             context.report({ node, messageId: "missingTypeParameter" })
           }

src/rules/require-event-dispatcher-types.ts

@@ -1,4 +1,4 @@
-- message: Type parameters missing for the createEventDispatcher function call.
+- message: Type parameters missing for the `createEventDispatcher` function call.
   line: 4
   column: 20
   suggestions: null

tests/fixtures/rules/require-event-dispatcher-types/invalid/import-alias01-errors.yaml

@@ -1,4 +1,4 @@
-- message: Type parameters missing for the createEventDispatcher function call.
+- message: Type parameters missing for the `createEventDispatcher` function call.
   line: 4
   column: 20
   suggestions: null