Skip to content

Commit 1aa3e48

Browse files
committed
Update of challenges service to leverage v3 API problems
1 parent 3645f8c commit 1aa3e48

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"lint:js": "./node_modules/.bin/eslint --ext .js,.jsx .",
2929
"test": "npm run lint && npm run jest"
3030
},
31-
"version": "0.0.7",
31+
"version": "0.0.8",
3232
"dependencies": {
3333
"isomorphic-fetch": "^2.2.1",
3434
"le_node": "^1.7.0",

src/services/challenges.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -181,13 +181,14 @@ export function normalizeChallengeDetails(v3, v3Filtered, v3User, username) {
181181
/* Taking phases from v3_filtered, because dates are not correct in v3 */
182182
currentPhases: v3Filtered.currentPhases || [],
183183

184-
/* Taking winners from v3_filtered, because winners are returned empty in v3 */
185-
winners: v3Filtered.winners || [],
186-
187184
/* v3 returns incorrect value for numberOfSubmissions for some reason */
188185
numSubmissions: v3Filtered.numSubmissions,
189186
groups,
190187
});
188+
189+
/* Taking winners from v3_filtered, because winners are returned empty in v3 */
190+
/* TODO: Enforced due to problems with /v3/challenge/{ID} endpoint */
191+
challenge.winners = v3Filtered.winners || [];
191192
}
192193

193194
// Fill missing data from v3_user

0 commit comments

Comments
 (0)