Skip to content
This repository was archived by the owner on May 14, 2021. It is now read-only.

Doesn't properly handle contextual selectors #34

Closed
corbanbrook opened this issue Jun 12, 2017 · 3 comments
Closed

Doesn't properly handle contextual selectors #34

corbanbrook opened this issue Jun 12, 2017 · 3 comments

Comments

@corbanbrook
Copy link

Causes errors to trigger when using contextual selectors like ${Button}

ie.

export const ButtonGroup = styled.div`
  white-space: nowrap;

  > ${Button} {
    margin: 0;
    border-radius: 0;
    vertical-align: top;
  }
`
149:28  ✖  Expected "$Button" to be "$button"     selector-type-case
 149:28  ✖  Unexpected unknown type selector       selector-type-no-unknown
            "$Button"
@corbanbrook corbanbrook changed the title Don't properly handle contextual selectors Doesn't properly handle contextual selectors Jun 12, 2017
@ghost
Copy link

ghost commented Jun 12, 2017

Thanks for the bug report! It would be great if you could submit a PR with a failing test for this. Otherwise I'll try to fix it myself asap.

@mxstbr mxstbr added the bug label Jun 12, 2017
@ghost ghost added the help welcome label Jun 29, 2017
@emilgoldsmith
Copy link
Member

This issue is heavily related to #54, bordering a duplicate. Will definitely be fixed by the same PR when it happens.

Also the first linting error should no longer be a problem due to #59, but the second one for sure.

@emilgoldsmith
Copy link
Member

This should be able to be handled with an sc-selector tag as added in #70 when we publish it in the near future (and maybe even inferred as proposed in #110 )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants