Run checkout inside docker

The title isn't 100% true,
because it depends on the settings (if docker is enabled).
There are still commands being executed outside docker readthedocs#5673.

Author: stsewd

readthedocs/projects/tasks.py

@@ -342,7 +342,7 @@ def __init__(
 
     # pylint: disable=arguments-differ
     def run(
-            self, pk, version_pk=None, build_pk=None, record=True, docker=None,
+            self, pk, version_pk=None, build_pk=None, record=True,
             force=False, **__
     ):
         """
@@ -365,18 +365,13 @@ def run(
         :param version_pk int: Project Version id (latest if None)
         :param build_pk int: Build id (if None, commands are not recorded)
         :param record bool: record a build object in the database
-        :param docker bool: use docker to build the project (if ``None``,
-            ``settings.DOCKER_ENABLE`` is used)
         :param force bool: force Sphinx build
 
         :returns: whether build was successful or not
 
         :rtype: bool
         """
         try:
-            if docker is None:
-                docker = settings.DOCKER_ENABLE
-
             self.project = self.get_project(pk)
             self.version = self.get_version(self.project, version_pk)
             self.build = self.get_build(build_pk)
@@ -418,7 +413,7 @@ def run(
             # No exceptions in the setup step, catch unhandled errors in the
             # build steps
             try:
-                self.run_build(docker=docker, record=record)
+                self.run_build(record=record)
             except Exception as e:  # noqa
                 log.exception(
                     'An unhandled exception was raised during project build',
@@ -451,7 +446,11 @@ def run_setup(self, record=True):
 
         Return True if successful.
         """
-        self.setup_env = LocalBuildEnvironment(
+        if settings.DOCKER_ENABLE:
+            env_cls = DockerBuildEnvironment
+        else:
+            env_cls = LocalBuildEnvironment
+        self.setup_env = env_cls(
             project=self.project,
             version=self.version,
             build=self.build,
@@ -517,19 +516,16 @@ def additional_vcs_operations(self):
         if version_repo.supports_submodules:
             version_repo.update_submodules(self.config)
 
-    def run_build(self, docker, record):
+    def run_build(self, record):
         """
         Build the docs in an environment.
 
-        :param docker: if ``True``, the build uses a ``DockerBuildEnvironment``,
-            otherwise it uses a ``LocalBuildEnvironment`` to run all the
-            commands to build the docs
         :param record: whether or not record all the commands in the ``Build``
             instance
         """
         env_vars = self.get_env_vars()
 
-        if docker:
+        if settings.DOCKER_ENABLE:
             env_cls = DockerBuildEnvironment
         else:
             env_cls = LocalBuildEnvironment

readthedocs/rtd_tests/tests/test_config_integration.py

@@ -457,7 +457,7 @@ def test_conda_environment(self, build_failed, checkout_path, tmpdir):
         )
 
         update_docs = self.get_update_docs_task()
-        update_docs.run_build(docker=False, record=False)
+        update_docs.run_build(record=False)
 
         conda_file = path.join(str(base_path), conda_file)
         assert update_docs.config.conda.environment == conda_file