Never link to the dashboard from the footer

Closes readthedocs#6137

We use the `get_absolute_url` in other parts of the code
where it makes sense to link to the dashboard.
So I'm adding an additional parameter.

Author: stsewd

readthedocs/api/v2/views/footer_views.py

@@ -44,7 +44,9 @@ def get_version_compare_data(project, base_version=None):
         'is_highest': True,
     }
     if highest_version_obj:
-        ret_val['url'] = highest_version_obj.get_absolute_url()
+        # Never link to the dashboard,
+        # users reading the docs may don't have access to the dashboard.
+        ret_val['url'] = highest_version_obj.get_absolute_url(link_to_dashboard=False)
         ret_val['slug'] = highest_version_obj.slug
     if base_version and base_version.slug != LATEST:
         try:

readthedocs/builds/models.py

@@ -77,7 +77,6 @@
 from readthedocs.projects.models import APIProject, Project
 from readthedocs.projects.version_handling import determine_stable_version
 
-
 log = logging.getLogger(__name__)
 
 
@@ -289,7 +288,13 @@ def commit_name(self):
         )
         return self.identifier
 
-    def get_absolute_url(self):
+    def get_absolute_url(self, link_to_dashboard=True):
+        """
+        Get absolute url to the docs of the version.
+
+        :param link_to_dashboard: If `False` we never try to link to the dashboard,
+                                  we link to the docs even if they result in a 404.
+        """
         # Hack external versions for now.
         # TODO: We can integrate them into the resolver
         # but this is much simpler to handle since we only link them a couple places for now
@@ -299,7 +304,7 @@ def get_absolute_url(self):
                 f'{self.project.slug}/{self.slug}/index.html'
             return url
 
-        if not self.built and not self.uploaded:
+        if not self.built and not self.uploaded and link_to_dashboard:
             return reverse(
                 'project_version_detail',
                 kwargs={