Don't compare inactive or non build versions

This is a better approach for readthedocs#6353

Author: stsewd

readthedocs/api/v2/views/footer_views.py

@@ -26,7 +26,10 @@ def get_version_compare_data(project, base_version=None):
     :param base_version: We assert whether or not the base_version is also the
                          highest version in the resulting "is_highest" value.
     """
-    versions_qs = Version.internal.public(project=project)
+    versions_qs = (
+        Version.internal.public(project=project)
+        .filter(built=True, active=True)
+    )
 
     # Take preferences over tags only if the project has at least one tag
     if versions_qs.filter(type=TAG).exists():
@@ -46,7 +49,7 @@ def get_version_compare_data(project, base_version=None):
     if highest_version_obj:
         # Never link to the dashboard,
         # users reading the docs may don't have access to the dashboard.
-        ret_val['url'] = highest_version_obj.get_absolute_url(link_to_dashboard=False)
+        ret_val['url'] = highest_version_obj.get_absolute_url()
         ret_val['slug'] = highest_version_obj.slug
     if base_version and base_version.slug != LATEST:
         try:

readthedocs/builds/models.py

@@ -289,13 +289,8 @@ def commit_name(self):
         )
         return self.identifier
 
-    def get_absolute_url(self, link_to_dashboard=True):
-        """
-        Get absolute url to the docs of the version.
-
-        :param link_to_dashboard: If `False` we never try to link to the dashboard,
-                                  we link to the docs even if they result in a 404.
-        """
+    def get_absolute_url(self):
+        """Get absolute url to the docs of the version."""
         # Hack external versions for now.
         # TODO: We can integrate them into the resolver
         # but this is much simpler to handle since we only link them a couple places for now
@@ -305,7 +300,7 @@ def get_absolute_url(self, link_to_dashboard=True):
                 f'{self.project.slug}/{self.slug}/index.html'
             return url
 
-        if not self.built and not self.uploaded and link_to_dashboard:
+        if not self.built and not self.uploaded:
             return reverse(
                 'project_version_detail',
                 kwargs={

readthedocs/rtd_tests/tests/test_footer.py

@@ -124,6 +124,7 @@ class TestVersionCompareFooter(TestCase):
 
     def setUp(self):
         self.pip = Project.objects.get(slug='pip')
+        self.pip.versions.update(built=True)
 
     def test_highest_version_from_stable(self):
         base_version = self.pip.get_stable_version()
@@ -150,7 +151,7 @@ def test_highest_version_from_lower(self):
         self.assertDictEqual(valid_data, returned_data)
 
     def test_highest_version_from_latest(self):
-        Version.objects.create_latest(project=self.pip)
+        Version.objects.create_latest(project=self.pip, built=True)
         base_version = self.pip.versions.get(slug=LATEST)
         valid_data = {
             'project': 'Version 0.8.1 of Pip (19)',
@@ -177,6 +178,7 @@ def test_highest_version_over_branches(self):
             identifier='1.0.0',
             type=TAG,
             active=True,
+            built=True,
         )
 
         base_version = self.pip.versions.get(slug='0.8.1')
@@ -221,6 +223,7 @@ def test_highest_version_without_tags(self):
             identifier='2.0.0',
             type=BRANCH,
             active=True,
+            built=True,
         )
         valid_data = {
             'project': 'Version 2.0.0 of Pip ({})'.format(version.pk),