Merge pull request readthedocs#5664 from saadmk11/fix-lint-notification-restapi-config

pylint fix for notifications, restapi and config

Author: stsewd

readthedocs/config/models.py

@@ -5,7 +5,7 @@
 from readthedocs.config.utils import to_dict
 
 
-class Base(object):
+class Base:
 
     """
     Base class for every configuration.

readthedocs/notifications/notification.py

@@ -168,18 +168,16 @@ def get_message(self, success):
                 else:
                     # log the error but not crash
                     log.error(
-                        "Notification {} has no key '{}' for {} messages".format(
-                            self.__class__.__name__,
-                            self.reason,
-                            'success' if self.success else 'failure',
-                        ),
+                        "Notification %s has no key '%s' for %s messages",
+                        self.__class__.__name__,
+                        self.reason,
+                        'success' if self.success else 'failure',
                     )
             else:
                 log.error(
-                    '{}.{}_message is a dictionary but no reason was provided'.format(
-                        self.__class__.__name__,
-                        'success' if self.success else 'failure',
-                    ),
+                    '%s.%s_message is a dictionary but no reason was provided',
+                    self.__class__.__name__,
+                    'success' if self.success else 'failure',
                 )
         else:
             msg = message

readthedocs/restapi/views/model_views.py

@@ -219,10 +219,11 @@ def sync_versions(self, request, **kwargs):  # noqa: D205
         new_stable = project.get_stable_version()
         if promoted_version and new_stable and new_stable.active:
             log.info(
-                'Triggering new stable build: {project}:{version}'.format(
-                    project=project.slug,
-                    version=new_stable.identifier,
-                ),
+                'Triggering new stable build: %(project)s:%(version)s',
+                {
+                    'project': project.slug,
+                    'version': new_stable.identifier,
+                }
             )
             trigger_build(project=project, version=new_stable)