Merge pull request readthedocs#5567 from rtfd/davidfischer/non-mobile-fixed-footer

Non mobile fixed footer ads

Author: ericholscher

media/css/readthedocs-doc-embed.css

@@ -168,30 +168,46 @@ div.ethical-footer {
     background-color: #eee;
     border-top: 1px solid #bfbfbf;
     font-size: 12px;
-    line-height: 16px;
-    padding: 0.5em 2.5em;
+    line-height: 1.5;
+    padding: 0.5em 1.5em;
     text-align: center;
     color: #404040;
     width: 100%;    /* Fallback for Opera Mini */
     width: 100vw;
 }
+@media (min-width: 769px) {
+    /* Improve viewing on non-mobile */
+    .ethical-fixedfooter {
+        font-size: 13px;
+        padding: 1em 1.5em;
+    }
+}
+.ethical-fixedfooter .ethical-text:before {
+    margin-right: 4px;
+    padding: 2px 6px;
+    border-radius: 3px;
+    background-color: #4caf50;
+    color: #fff;
+    content: "Sponsored";
+}
+.ethical-fixedfooter .ethical-callout {
+    color: #999;
+    padding-left: 6px;
+    white-space: nowrap;
+}
 .ethical-fixedfooter a,
 .ethical-fixedfooter a:hover,
 .ethical-fixedfooter a:active,
 .ethical-fixedfooter a:visited {
-    color: #004B6B;
-    text-decoration: underline;
+    color: #404040;
+    text-decoration: none;
 }
 .ethical-fixedfooter .ethical-close {
     position: absolute;
     top: 0;
     right: 5px;
-    font-size: 15px;
-    line-height: 15px;
-}
-.ethical-fixedfooter .ethical-close a {
-    color: black;
-    text-decoration: none;
+    font-size: 20px;
+    line-height: 20px;
 }
 
 /* RTD Theme specific customizations */
@@ -208,6 +224,13 @@ div.ethical-footer {
     line-height: 20px;
 }
 
+@media (min-width: 769px) {
+    /* Make sure the fixed footer ad is under the RTD theme version selector */
+    .wy-body-for-nav .ethical-fixedfooter {
+        padding-left: 300px;
+    }
+}
+
 /* Alabaster specific customizations */
 .ethical-alabaster a.ethical-image-link {
     /* Alabaster adds a border even to image links on hover */

readthedocs/core/static-src/core/js/doc-embed/sponsorship.js

@@ -67,9 +67,6 @@ function create_sidebar_placement() {
         if (!offset || offset.top > $(window).height()) {
             // If this is off screen, lower the priority
             priority = constants.LOW_PROMO_PRIORITY;
-        } else if (bowser && !bowser.mobile) {
-            // If this isn't mobile, then the ad will be ATF, so raise the priority
-            priority = constants.MAXIMUM_PROMO_PRIORITY;
         }
 
         return {
@@ -131,20 +128,21 @@ function create_footer_placement() {
 function create_fixed_footer_placement() {
     var element_id = 'rtd-' + (Math.random() + 1).toString(36).substring(4);
     var display_type = constants.PROMO_TYPES.FIXED_FOOTER;
+    var priority = constants.DEFAULT_PROMO_PRIORITY;
 
-    // Only propose the fixed footer ad for mobile
     if (bowser && bowser.mobile) {
-        $('<div />').attr('id', element_id).appendTo('body');
-        return {
-            'div_id': element_id,
-            'display_type': display_type,
-
-            // Prioritize mobile ads when on mobile
-            'priority': constants.MAXIMUM_PROMO_PRIORITY,
-        };
+        // If this is mobile, then prioritize fixed footer
+        priority = constants.MAXIMUM_PROMO_PRIORITY;
     }
 
-    return null;
+    $('<div />').attr('id', element_id).appendTo('body');
+    return {
+        'div_id': element_id,
+        'display_type': display_type,
+
+        // Prioritize mobile ads when on mobile
+        'priority': priority,
+    };
 }
 
 function Promo(data) {