Merge pull request readthedocs#6087 from dojutsu-user/remove-highlight-url-params

Remove 'highlight' URL param from search results

Author: ericholscher

readthedocs/core/static-src/core/js/doc-embed/search.js

@@ -77,7 +77,8 @@ function attach_elastic_search_query(data) {
                         }
 
                         // Creating the result from elements
-                        var link = doc.link + DOCUMENTATION_OPTIONS.FILE_SUFFIX + "?highlight=" + $.urlencode(query);
+                        var link = doc.link + DOCUMENTATION_OPTIONS.FILE_SUFFIX;
+
                         var item = $('<a>', {'href': link});
 
                         item.html(title);

readthedocs/core/static/core/js/readthedocs-doc-embed.js

@@ -180,14 +180,14 @@ <h3>
 
                   {% elif 'page' in result.meta.index %}
                     {% with "100" as MAX_SUBSTRING_LIMIT %}
-                      <a href="{% doc_url result.project|get_project result.version result.full_path %}?highlight={{ query }}">
+                      <a href="{% doc_url result.project|get_project result.version result.full_path %}">
                         {{ result.project }} - {% if result.meta.highlight.title %} {{ result.meta.highlight.title.0|safe }} {% else %} {{ result.title }} {% endif %}
                       </a>
 
                       {% for inner_hit in result.meta.inner_hits %}
                         {% if inner_hit.type == 'domains' %}
                           <p>
-                            <a href="{% doc_url result.project|get_project result.version result.full_path %}?highlight= {{ query }}#{{ inner_hit.source.anchor }}">
+                            <a href="{% doc_url result.project|get_project result.version result.full_path %}#{{ inner_hit.source.anchor }}">
                               {% if inner_hit.highlight|get_key_or_none:"domains.name" %}
                                 {% with domain_name=inner_hit.highlight|get_key_or_none:"domains.name" %}
                                   [{{ inner_hit.source.role_name }}]: {{ domain_name.0|safe }}
@@ -211,7 +211,7 @@ <h3>
 
                         {% elif inner_hit.type == 'sections' %}
                           <p>
-                            <a href="{% doc_url result.project|get_project result.version result.full_path %}?highlight={{ query }}#{{ inner_hit.source.id }}">
+                            <a href="{% doc_url result.project|get_project result.version result.full_path %}#{{ inner_hit.source.id }}">
                               {% if inner_hit.highlight|get_key_or_none:"sections.title" %}
                                 {% with section_title=inner_hit.highlight|get_key_or_none:"sections.title" %}
                                   {{ section_title.0|safe }}