Skip to content

Commit 2f6fe90

Browse files
committed
Cleanup a little documentation_type from footer
This doesn't remove documentation_type completely from the footer, but makes it more clear what we are really using. We don't use `readthedocssinglehtml` as proven in readthedocs/readthedocs-sphinx-ext#58 We don't set `page` for mkdocs projects: https://github.com/rtfd/readthedocs.org/blob/f1c15d4f22af0ba7ebf762df1d49f7c28e8d01e5/readthedocs/doc_builder/backends/mkdocs.py#L207-L207 Ref readthedocs#4638
1 parent 9b37cd9 commit 2f6fe90

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

readthedocs/restapi/views/footer_views.py

+1-6
Original file line numberDiff line numberDiff line change
@@ -95,13 +95,8 @@ def footer_html(request):
9595
main_project = project.main_language_project or project
9696

9797
if page_slug and page_slug != 'index':
98-
if (
99-
main_project.documentation_type == 'sphinx_htmldir' or
100-
main_project.documentation_type == 'mkdocs'
101-
):
98+
if main_project.documentation_type == 'sphinx_htmldir':
10299
path = page_slug + '/'
103-
elif main_project.documentation_type == 'sphinx_singlehtml':
104-
path = 'index.html#document-' + page_slug
105100
else:
106101
path = page_slug + '.html'
107102
else:

0 commit comments

Comments
 (0)