Skip to content

Commit 044f200

Browse files
authored
Merge pull request readthedocs#6170 from stsewd/fix-tests-on-com
Require login for old redirect
2 parents e50345c + 8bb3540 commit 044f200

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

readthedocs/projects/urls/private.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
"""Project URLs for authenticated users."""
22

33
from django.conf.urls import url
4+
from django.contrib.auth.decorators import login_required
45
from django.views.generic.base import RedirectView
56

67
from readthedocs.constants import pattern_opts
@@ -45,7 +46,9 @@
4546
),
4647
url(
4748
r'^(?P<project_slug>[-\w]+)/$',
48-
RedirectView.as_view(pattern_name='projects_detail', permanent=True),
49+
login_required(
50+
RedirectView.as_view(pattern_name='projects_detail', permanent=True),
51+
),
4952
name='projects_manage',
5053
),
5154
url(

readthedocs/rtd_tests/tests/test_privacy_urls.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -311,11 +311,6 @@ class PrivateProjectUnauthAccessTest(PrivateProjectMixin, TestCase):
311311
# Auth protected
312312
default_status_code = 302
313313

314-
response_data = {
315-
# Old url, it redirects to a view that doesn't requires login.
316-
'/dashboard/pip/': {'status_code': 301},
317-
}
318-
319314
def login(self):
320315
pass
321316

0 commit comments

Comments
 (0)