Update to latest eslint perfectionist

The new version of `eslint-plugin-perfectionist` does not export the
configs directly anymore as of [2a7eec2][1].

As a result we now have to refer to the config differently.

[1]: azat-io/eslint-plugin-perfectionist@2a7eec2#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

Author: stschulte

eslint.config.js

@@ -1,23 +1,27 @@
 import eslint from "@eslint/js";
 import gitignore from "eslint-config-flat-gitignore";
-import perfectionistNatural from 'eslint-plugin-perfectionist/configs/recommended-natural'
+import perfectionist from 'eslint-plugin-perfectionist'
 import tseslint from "typescript-eslint";
 
 export default tseslint.config(
   gitignore(),
   eslint.configs.recommended,
-  ...tseslint.configs.recommended,
+  ...tseslint.configs.strictTypeChecked,
   {
     languageOptions: {
       parserOptions: {
-        ecmaVersion: "latest",
-        project: "./tsconfig.json",
-        sourceType: "module",
-      },
+        projectService: true,
+        tsconfigRootDir: import.meta.dirname,
+      }
     },
     rules: {
       "@typescript-eslint/no-explicit-any": "off",
     },
   },
-  perfectionistNatural
+  {
+    // disable type-aware linting on JS files
+    files: ['**/*.js'],
+    ...tseslint.configs.disableTypeChecked,
+  },
+  perfectionist.configs["recommended-natural"]
 );

package-lock.json

@@ -16,8 +16,8 @@
   },
   "scripts": {
     "build": "tsc -p tsconfig.build.json",
-    "lint": "eslint -c ./eslint.config.js .",
-    "lint:fix": "eslint -c ./eslint.config.js --fix .",
+    "lint": "eslint .",
+    "lint:fix": "eslint --fix .",
     "test": "vitest run",
     "test:coverage": "vitest run --coverage",
     "validate": "tsc --noEmit",
@@ -34,22 +34,22 @@
   },
   "homepage": "https://github.com/stschulte/aws-sdk-client-mock-vitest#readme",
   "dependencies": {
-    "@vitest/expect": "^2.0.1",
+    "@vitest/expect": "^2.0.5",
     "tslib": "^2.6.3"
   },
   "devDependencies": {
-    "@aws-sdk/client-ec2": "^3.609.0",
-    "@aws-sdk/client-s3": "^3.609.0",
-    "@eslint/js": "^9.6.0",
+    "@aws-sdk/client-ec2": "^3.631.0",
+    "@aws-sdk/client-s3": "^3.631.0",
+    "@eslint/js": "^9.9.0",
     "@smithy/types": "^3.3.0",
-    "@types/node": "^20.14.10",
-    "@vitest/coverage-v8": "^2.0.1",
+    "@types/node": "^22.3.0",
+    "@vitest/coverage-v8": "^2.0.5",
     "aws-sdk-client-mock": "^4.0.1",
-    "eslint": "^8.57.0",
-    "eslint-config-flat-gitignore": "^0.1.6",
-    "eslint-plugin-perfectionist": "^2.11.0",
-    "typescript": "^5.5.3",
-    "typescript-eslint": "^7.16.0",
-    "vitest": "^2.0.1"
+    "eslint": "^9.9.0",
+    "eslint-config-flat-gitignore": "^0.1.8",
+    "eslint-plugin-perfectionist": "^3.2.0",
+    "typescript": "^5.5.4",
+    "typescript-eslint": "^8.1.0",
+    "vitest": "^2.0.5"
   }
 }

package.json

@@ -111,6 +111,7 @@ function formatCalls(
       "Received:",
       "",
       ...calls.flatMap((call, index) => {
+        /* eslint-disable @typescript-eslint/no-unsafe-assignment */
         const input = call.args[0].input;
         return [
           `   ${ordinalOf(index + 1)} ${command.name} call`,
@@ -125,7 +126,7 @@ function formatCalls(
           ""
         ].filter(notNull);
       }),
-      `Number of calls: ${calls.length}`
+      `Number of calls: ${calls.length.toString()}`
     ].join("\n");
 }
 
@@ -141,8 +142,8 @@ const toHaveReceivedCommandTimes: CustomMatcherFn = function(
   return {
     message: () => {
       const message = isNot
-        ? `expected "${command.name}" to not be called ${times} times`
-        : `expected "${command.name}" to be called ${times} times, but got ${callCount} times`;
+        ? `expected "${command.name}" to not be called ${times.toString()} times`
+        : `expected "${command.name}" to be called ${times.toString()} times, but got ${callCount.toString()} times`;
       return formatCalls(this, client, command, undefined, message);
     },
     pass
@@ -161,7 +162,7 @@ const toHaveReceivedCommandOnce: CustomMatcherFn = function(
     message: () => {
       const message = isNot
         ? `expected "${command.name}" to not be called once`
-        : `expected "${command.name}" to be called once, but got ${callCount} times`;
+        : `expected "${command.name}" to be called once, but got ${callCount.toString()} times`;
       return formatCalls(this, client, command, undefined, message);
     },
     pass
@@ -179,7 +180,7 @@ const toHaveReceivedCommand: CustomMatcherFn = function(
   return {
     message: () => {
       const message = isNot
-        ? `expected "${command.name}" to not be called at all, but actually been called ${callCount} times`
+        ? `expected "${command.name}" to not be called at all, but actually been called ${callCount.toString()} times`
         : `expected "${command.name}" to be called at least once`;
       return formatCalls(this, client, command, undefined, message);
     },

src/matcher.ts

@@ -1,12 +1,13 @@
 export function ordinalOf(n: number): string {
   const j = n % 10;
   const k = n % 100;
-  if (j === 1 && k !== 11) return `${n}st`;
-  if (j === 2 && k !== 12) return `${n}nd`;
-  if (j === 3 && k !== 13) return `${n}rd`;
-  return `${n}th`;
+  const s = n.toString()
+  if (j === 1 && k !== 11) return `${s}st`;
+  if (j === 2 && k !== 12) return `${s}nd`;
+  if (j === 3 && k !== 13) return `${s}rd`;
+  return `${s}th`;
 }
 
-export function notNull<T>(obj: T | null): obj is T {
+export function notNull<T>(obj: null | T): obj is T {
   return obj !== null;
 }

src/utils.ts

@@ -39,7 +39,7 @@ expect.extend({
 });
 
 describe("toReceiveCommandTimes", () => {
-  it("should pass with 0 received commands", async () => {
+  it("should pass with 0 received commands", () => {
     const s3Mock = mockClient(S3Client);
     expect(s3Mock).toReceiveCommandTimes(PutObjectCommand, 0);
   });
@@ -67,7 +67,7 @@ describe("toReceiveCommandTimes", () => {
   });
 
   describe("not", () => {
-    it("should pass when not called", async () => {
+    it("should pass when not called", () => {
       const s3Mock = mockClient(S3Client);
       expect(s3Mock).not.toReceiveCommandTimes(PutObjectCommand, 1);
     });
@@ -89,7 +89,7 @@ describe("toReceiveCommandTimes", () => {
 });
 
 describe("toHaveReceivedCommandTimes", () => {
-  it("should pass with 0 received commands", async () => {
+  it("should pass with 0 received commands", () => {
     const s3Mock = mockClient(S3Client);
     expect(s3Mock).toHaveReceivedCommandTimes(PutObjectCommand, 0);
   });
@@ -117,7 +117,7 @@ describe("toHaveReceivedCommandTimes", () => {
   });
 
   describe("not", () => {
-    it("should pass when not called", async () => {
+    it("should pass when not called", () => {
       const s3Mock = mockClient(S3Client);
       expect(s3Mock).not.toHaveReceivedCommandTimes(PutObjectCommand, 1);
     });
@@ -146,7 +146,7 @@ describe("toReceiveCommandOnce", () => {
     expect(s3Mock).toReceiveCommandOnce(GetObjectCommand);
   });
 
-  it.fails("should fail when not called", async () => {
+  it.fails("should fail when not called", () => {
     const s3Mock = mockClient(S3Client);
     expect(s3Mock).toReceiveCommandOnce(GetObjectCommand);
   });
@@ -169,7 +169,7 @@ describe("toReceiveCommandOnce", () => {
   });
 
   describe("not", () => {
-    it("should pass when not called", async () => {
+    it("should pass when not called", () => {
       const s3Mock = mockClient(S3Client);
       expect(s3Mock).not.toReceiveCommandOnce(GetObjectCommand);
     });
@@ -205,7 +205,7 @@ describe("toHaveReceivedCommandOnce", () => {
     expect(s3Mock).toHaveReceivedCommandOnce(GetObjectCommand);
   });
 
-  it.fails("should fail when not called", async () => {
+  it.fails("should fail when not called", () => {
     const s3Mock = mockClient(S3Client);
     expect(s3Mock).toHaveReceivedCommandOnce(GetObjectCommand);
   });
@@ -228,7 +228,7 @@ describe("toHaveReceivedCommandOnce", () => {
   });
 
   describe("not", () => {
-    it("should pass when not called", async () => {
+    it("should pass when not called", () => {
       const s3Mock = mockClient(S3Client);
       expect(s3Mock).not.toHaveReceivedCommandOnce(GetObjectCommand);
     });
@@ -258,7 +258,7 @@ describe("toHaveReceivedCommandOnce", () => {
 });
 
 describe("toReceiveCommand", () => {
-  it.fails("should fail when no command received", async () => {
+  it.fails("should fail when no command received", () => {
     const s3Mock = mockClient(S3Client);
     expect(s3Mock).toReceiveCommand(GetObjectCommand);
   });
@@ -286,7 +286,7 @@ describe("toReceiveCommand", () => {
   });
 
   describe("not", () => {
-    it("should pass when no command received", async () => {
+    it("should pass when no command received", () => {
       const s3Mock = mockClient(S3Client);
       expect(s3Mock).not.toReceiveCommand(GetObjectCommand);
     });
@@ -316,7 +316,7 @@ describe("toReceiveCommand", () => {
 });
 
 describe("toHaveReceivedCommand", () => {
-  it.fails("should fail when no command received", async () => {
+  it.fails("should fail when no command received", () => {
     const s3Mock = mockClient(S3Client);
     expect(s3Mock).toHaveReceivedCommand(GetObjectCommand);
   });
@@ -344,7 +344,7 @@ describe("toHaveReceivedCommand", () => {
   });
 
   describe("not", () => {
-    it("should pass when no command received", async () => {
+    it("should pass when no command received", () => {
       const s3Mock = mockClient(S3Client);
       expect(s3Mock).not.toHaveReceivedCommand(GetObjectCommand);
     });
@@ -471,7 +471,7 @@ describe("toReceiveCommandWith", () => {
   });
 
   describe("not", () => {
-    it("shoud pass when never called", async () => {
+    it("shoud pass when never called", () => {
       const s3Mock = mockClient(S3Client);
       expect(s3Mock).not.toReceiveCommandWith(PutObjectCommand, {
         Bucket: "foo",
@@ -623,7 +623,7 @@ describe("toHaveReceivedCommandWith", () => {
   });
 
   describe("not", () => {
-    it("shoud pass when never called", async () => {
+    it("shoud pass when never called", () => {
       const s3Mock = mockClient(S3Client);
       expect(s3Mock).not.toHaveReceivedCommandWith(PutObjectCommand, {
         Bucket: "foo",
@@ -975,7 +975,7 @@ describe("toReceiveLastCommandWith", () => {
     });
   });
 
-  it.fails("should fail when not called at all", async () => {
+  it.fails("should fail when not called at all", () => {
     const s3Mock = mockClient(S3Client);
     expect(s3Mock).toReceiveLastCommandWith(GetObjectCommand, {
       Bucket: "foo",
@@ -984,7 +984,7 @@ describe("toReceiveLastCommandWith", () => {
   });
 
   describe("not", () => {
-    it("should pass when not called", async () => {
+    it("should pass when not called", () => {
       const s3Mock = mockClient(S3Client);
       expect(s3Mock).not.toReceiveLastCommandWith(GetObjectCommand, {
         Bucket: "foo",
@@ -1106,7 +1106,7 @@ describe("toHaveReceivedLastCommandWith", () => {
     });
   });
 
-  it.fails("should fail when not called at all", async () => {
+  it.fails("should fail when not called at all", () => {
     const s3Mock = mockClient(S3Client);
     expect(s3Mock).toHaveReceivedLastCommandWith(GetObjectCommand, {
       Bucket: "foo",
@@ -1115,7 +1115,7 @@ describe("toHaveReceivedLastCommandWith", () => {
   });
 
   describe("not", () => {
-    it("should pass when not called", async () => {
+    it("should pass when not called", () => {
       const s3Mock = mockClient(S3Client);
       expect(s3Mock).not.toHaveReceivedLastCommandWith(GetObjectCommand, {
         Bucket: "foo",

tests/matcher.test.ts

@@ -17,7 +17,7 @@ describe("notNull", () => {
 });
 
 describe("ordinalOf", () => {
-  const cases: Array<[number, string]> = [
+  const cases: [number, string][] = [
     [1, "1st"],
     [2, "2nd"],
     [3, "3rd"],

tests/utils.test.ts

@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/no-empty-interface */
+/* eslint-disable @typescript-eslint/no-empty-object-type */
 import "vitest";
 
 import { CustomMatcher } from "../src/matcher.ts";