Skip to content

Commit 2f54ee5

Browse files
committed
Address PR comments
1 parent 7c00160 commit 2f54ee5

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

lib/services.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ module.exports = function generateServices(app, options) {
5050
apiUrl: arguments[2],
5151
};
5252
}
53-
var oldOptions = options;
5453

5554
options = extend({
5655
ngModuleName: 'lbServices',

lib/services.template.ejs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -389,6 +389,7 @@ if (typeof module !== 'undefined' && typeof exports !== 'undefined' &&
389389
},
390390
};
391391
}])
392+
392393
/**
393394
* @ngdoc object
394395
* @name <%-: moduleName %>.LoopBackResourceProvider

test.e2e/given.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ define(['angular', 'angularMocks', 'angularResource'], function(angular) {
5858
* ```
5959
*/
6060
given.servicesForLoopBackApp = function(options, cb) {
61-
if (! options.name) {
61+
if (!options.name) {
6262
options.name = generateUniqueServiceName(options.name);
6363
}
6464

test.e2e/test-server.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -151,15 +151,16 @@ masterApp.listen(port, function() {
151151

152152
function generateService(generator, lbApp, apiUrl, opts) {
153153
var servicesScript;
154-
if (typeof opts.includeSchema !== 'undefined' ||
155-
typeof opts.includeCommonModules !== 'undefined' ||
156-
typeof opts.namespaceModels !== 'undefined' ||
157-
typeof opts.namespaceDelimiter !== 'undefined') {
154+
if (opts.includeSchema !== undefined ||
155+
opts.includeCommonModules !== undefined ||
156+
opts.namespaceModels !== undefined ||
157+
opts.namespaceDelimiter !== undefined) {
158158
// the new options-based API
159159

160160
// build options object for new options-based API
161161
var generatorOptions = opts;
162162
generatorOptions.ngModuleName = opts.name;
163+
generatorOptions.apiUrl = apiUrl;
163164

164165
servicesScript = generator.services(lbApp, generatorOptions);
165166
} else {

0 commit comments

Comments
 (0)