Skip to content

Commit 737e6f7

Browse files
realDuYuanChaogithub-actionspoyea
authored andcommitted
Fixed LGTM and typehint (TheAlgorithms#3970)
* fixed LGTM fixed typehint * updating DIRECTORY.md * Update lucas_series.py * Update lucas_series.py Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com> Co-authored-by: John Law <[email protected]>
1 parent d557e3d commit 737e6f7

File tree

2 files changed

+23
-16
lines changed

2 files changed

+23
-16
lines changed

Diff for: DIRECTORY.md

+11-1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@
2626

2727
## Bit Manipulation
2828
* [Binary And Operator](https://github.com/TheAlgorithms/Python/blob/master/bit_manipulation/binary_and_operator.py)
29+
* [Binary Count Setbits](https://github.com/TheAlgorithms/Python/blob/master/bit_manipulation/binary_count_setbits.py)
30+
* [Binary Count Trailing Zeros](https://github.com/TheAlgorithms/Python/blob/master/bit_manipulation/binary_count_trailing_zeros.py)
2931
* [Binary Or Operator](https://github.com/TheAlgorithms/Python/blob/master/bit_manipulation/binary_or_operator.py)
3032
* [Binary Xor Operator](https://github.com/TheAlgorithms/Python/blob/master/bit_manipulation/binary_xor_operator.py)
3133
* [Single Bit Manipulation Operations](https://github.com/TheAlgorithms/Python/blob/master/bit_manipulation/single_bit_manipulation_operations.py)
@@ -47,7 +49,7 @@
4749
* [Atbash](https://github.com/TheAlgorithms/Python/blob/master/ciphers/atbash.py)
4850
* [Base16](https://github.com/TheAlgorithms/Python/blob/master/ciphers/base16.py)
4951
* [Base32](https://github.com/TheAlgorithms/Python/blob/master/ciphers/base32.py)
50-
* [Base64 Cipher](https://github.com/TheAlgorithms/Python/blob/master/ciphers/base64_cipher.py)
52+
* [Base64 Encoding](https://github.com/TheAlgorithms/Python/blob/master/ciphers/base64_encoding.py)
5153
* [Base85](https://github.com/TheAlgorithms/Python/blob/master/ciphers/base85.py)
5254
* [Beaufort Cipher](https://github.com/TheAlgorithms/Python/blob/master/ciphers/beaufort_cipher.py)
5355
* [Brute Force Caesar Cipher](https://github.com/TheAlgorithms/Python/blob/master/ciphers/brute_force_caesar_cipher.py)
@@ -101,6 +103,7 @@
101103
* [Decimal To Octal](https://github.com/TheAlgorithms/Python/blob/master/conversions/decimal_to_octal.py)
102104
* [Hexadecimal To Decimal](https://github.com/TheAlgorithms/Python/blob/master/conversions/hexadecimal_to_decimal.py)
103105
* [Molecular Chemistry](https://github.com/TheAlgorithms/Python/blob/master/conversions/molecular_chemistry.py)
106+
* [Octal To Decimal](https://github.com/TheAlgorithms/Python/blob/master/conversions/octal_to_decimal.py)
104107
* [Prefix Conversions](https://github.com/TheAlgorithms/Python/blob/master/conversions/prefix_conversions.py)
105108
* [Roman To Integer](https://github.com/TheAlgorithms/Python/blob/master/conversions/roman_to_integer.py)
106109
* [Temperature Conversions](https://github.com/TheAlgorithms/Python/blob/master/conversions/temperature_conversions.py)
@@ -207,6 +210,7 @@
207210
* [Heaps Algorithm Iterative](https://github.com/TheAlgorithms/Python/blob/master/divide_and_conquer/heaps_algorithm_iterative.py)
208211
* [Inversions](https://github.com/TheAlgorithms/Python/blob/master/divide_and_conquer/inversions.py)
209212
* [Kth Order Statistic](https://github.com/TheAlgorithms/Python/blob/master/divide_and_conquer/kth_order_statistic.py)
213+
* [Max Difference Pair](https://github.com/TheAlgorithms/Python/blob/master/divide_and_conquer/max_difference_pair.py)
210214
* [Max Subarray Sum](https://github.com/TheAlgorithms/Python/blob/master/divide_and_conquer/max_subarray_sum.py)
211215
* [Mergesort](https://github.com/TheAlgorithms/Python/blob/master/divide_and_conquer/mergesort.py)
212216
* [Peak](https://github.com/TheAlgorithms/Python/blob/master/divide_and_conquer/peak.py)
@@ -243,6 +247,9 @@
243247
* [Subset Generation](https://github.com/TheAlgorithms/Python/blob/master/dynamic_programming/subset_generation.py)
244248
* [Sum Of Subset](https://github.com/TheAlgorithms/Python/blob/master/dynamic_programming/sum_of_subset.py)
245249

250+
## Electronics
251+
* [Ohms Law](https://github.com/TheAlgorithms/Python/blob/master/electronics/ohms_law.py)
252+
246253
## File Transfer
247254
* [Receive File](https://github.com/TheAlgorithms/Python/blob/master/file_transfer/receive_file.py)
248255
* [Send File](https://github.com/TheAlgorithms/Python/blob/master/file_transfer/send_file.py)
@@ -804,6 +811,7 @@
804811
* [Gnome Sort](https://github.com/TheAlgorithms/Python/blob/master/sorts/gnome_sort.py)
805812
* [Heap Sort](https://github.com/TheAlgorithms/Python/blob/master/sorts/heap_sort.py)
806813
* [Insertion Sort](https://github.com/TheAlgorithms/Python/blob/master/sorts/insertion_sort.py)
814+
* [Intro Sort](https://github.com/TheAlgorithms/Python/blob/master/sorts/intro_sort.py)
807815
* [Iterative Merge Sort](https://github.com/TheAlgorithms/Python/blob/master/sorts/iterative_merge_sort.py)
808816
* [Merge Insertion Sort](https://github.com/TheAlgorithms/Python/blob/master/sorts/merge_insertion_sort.py)
809817
* [Merge Sort](https://github.com/TheAlgorithms/Python/blob/master/sorts/merge_sort.py)
@@ -877,6 +885,8 @@
877885
* [Get Imdb Top 250 Movies Csv](https://github.com/TheAlgorithms/Python/blob/master/web_programming/get_imdb_top_250_movies_csv.py)
878886
* [Get Imdbtop](https://github.com/TheAlgorithms/Python/blob/master/web_programming/get_imdbtop.py)
879887
* [Instagram Crawler](https://github.com/TheAlgorithms/Python/blob/master/web_programming/instagram_crawler.py)
888+
* [Instagram Pic](https://github.com/TheAlgorithms/Python/blob/master/web_programming/instagram_pic.py)
880889
* [Recaptcha Verification](https://github.com/TheAlgorithms/Python/blob/master/web_programming/recaptcha_verification.py)
881890
* [Slack Message](https://github.com/TheAlgorithms/Python/blob/master/web_programming/slack_message.py)
891+
* [Test Fetch Github Info](https://github.com/TheAlgorithms/Python/blob/master/web_programming/test_fetch_github_info.py)
882892
* [World Covid19 Stats](https://github.com/TheAlgorithms/Python/blob/master/web_programming/world_covid19_stats.py)

Diff for: maths/lucas_series.py

+12-15
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"""
44

55

6-
def recursive_lucas_number(n):
6+
def recursive_lucas_number(n_th_number: int) -> int:
77
"""
88
Returns the nth lucas number
99
>>> recursive_lucas_number(1)
@@ -19,17 +19,19 @@ def recursive_lucas_number(n):
1919
...
2020
TypeError: recursive_lucas_number accepts only integer arguments.
2121
"""
22-
if n == 1:
23-
return n
24-
if n == 0:
25-
return 2
26-
if not isinstance(n, int):
22+
if not isinstance(n_th_number, int):
2723
raise TypeError("recursive_lucas_number accepts only integer arguments.")
24+
if n_th_number == 0:
25+
return 2
26+
if n_th_number == 1:
27+
return 1
2828

29-
return recursive_lucas_number(n - 1) + recursive_lucas_number(n - 2)
29+
return recursive_lucas_number(n_th_number - 1) + recursive_lucas_number(
30+
n_th_number - 2
31+
)
3032

3133

32-
def dynamic_lucas_number(n: int) -> int:
34+
def dynamic_lucas_number(n_th_number: int) -> int:
3335
"""
3436
Returns the nth lucas number
3537
>>> dynamic_lucas_number(1)
@@ -45,14 +47,10 @@ def dynamic_lucas_number(n: int) -> int:
4547
...
4648
TypeError: dynamic_lucas_number accepts only integer arguments.
4749
"""
48-
if not isinstance(n, int):
50+
if not isinstance(n_th_number, int):
4951
raise TypeError("dynamic_lucas_number accepts only integer arguments.")
50-
if n == 0:
51-
return 2
52-
if n == 1:
53-
return 1
5452
a, b = 2, 1
55-
for i in range(n):
53+
for i in range(n_th_number):
5654
a, b = b, a + b
5755
return a
5856

@@ -62,7 +60,6 @@ def dynamic_lucas_number(n: int) -> int:
6260

6361
testmod()
6462
n = int(input("Enter the number of terms in lucas series:\n").strip())
65-
n = int(input("Enter the number of terms in lucas series:\n").strip())
6663
print("Using recursive function to calculate lucas series:")
6764
print(" ".join(str(recursive_lucas_number(i)) for i in range(n)))
6865
print("\nUsing dynamic function to calculate lucas series:")

0 commit comments

Comments
 (0)