Prevent singleton definition when fake objects are used

This change allows to implement and use fake objects during unit testing
Classes to be mocked will be extended by fake classes. Each fake class will define a fake singleton instance

Author: polldo

extras/test/CMakeLists.txt

@@ -0,0 +1,94 @@
+##########################################################################
+
+set(CMAKE_VERBOSE_MAKEFILE ON)
+cmake_minimum_required(VERSION 2.8)
+
+##########################################################################
+
+project(testArduinoBLE)
+
+##########################################################################
+
+include_directories(include)
+include_directories(include/util)
+include_directories(../../src)
+include_directories(../../src/local)
+include_directories(../../src/remote)
+include_directories(../../src/utility)
+include_directories(external/catch/v2.12.1/include)
+include_directories(external/fakeit/v2.0.5/include)
+
+##########################################################################
+
+set(CMAKE_CXX_STANDARD 11)
+set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin)
+
+##########################################################################
+
+set(TEST_TARGET_UUID_SRCS
+  src/Arduino.cpp
+  src/util/itoa.c
+  src/util/TestUtil.cpp
+  src/test_main.cpp
+  src/test_uuid/test_uuid.cpp
+  ../../src/utility/BLEUuid.cpp
+  src/util/String.cpp
+  src/util/Common.cpp
+)
+
+set(TEST_TARGET_DISC_DEVICE_SRCS
+  src/Arduino.cpp
+  src/util/itoa.c
+  src/util/TestUtil.cpp
+  src/util/String.cpp
+  src/util/Common.cpp
+  src/test_main.cpp
+  src/test_discovered_device/test_discovered_device.cpp
+  ../../src/utility/BLEUuid.cpp
+  ../../src/BLEDevice.cpp
+  ../../src/BLECharacteristic.cpp
+  ../../src/BLEDescriptor.cpp
+  ../../src/BLEService.cpp
+  ../../src/BLEAdvertisingData.cpp
+  ../../src/utility/ATT.cpp
+  #../../src/utility/GAP.cpp
+  ../../src/utility/HCI.cpp
+  ../../src/utility/GATT.cpp
+  ../../src/utility/L2CAPSignaling.cpp
+  ../../src/local/BLELocalAttribute.cpp
+  ../../src/local/BLELocalCharacteristic.cpp
+  ../../src/local/BLELocalDescriptor.cpp
+  ../../src/local/BLELocalDevice.cpp
+  ../../src/local/BLELocalService.cpp
+  ../../src/remote/BLERemoteAttribute.cpp
+  ../../src/remote/BLERemoteAdvertisingData.cpp
+  ../../src/remote/BLERemoteCharacteristic.cpp
+  ../../src/remote/BLERemoteDescriptor.cpp
+  ../../src/remote/BLERemoteDevice.cpp
+  ../../src/remote/BLERemoteService.cpp
+  ../../src/BLEStringCharacteristic.cpp
+  ../../src/BLETypedCharacteristics.cpp
+  # Fake classes 
+  src/util/HCIFakeTransport.cpp
+  src/test_discovered_device/FakeGAP.cpp
+)
+
+##########################################################################
+
+set(CMAKE_C_FLAGS   ${CMAKE_C_FLAGS}   "--coverage")
+set(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} "--coverage")
+
+##########################################################################
+
+add_executable(TEST_TARGET_UUID ${TEST_TARGET_UUID_SRCS})
+add_executable(TEST_TARGET_DISC_DEVICE ${TEST_TARGET_DISC_DEVICE_SRCS})
+
+##########################################################################
+
+# Build unit tests as a post build step
+add_custom_command(TARGET TEST_TARGET_UUID POST_BUILD
+  COMMAND ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/TEST_TARGET_UUID
+)
+add_custom_command(TARGET TEST_TARGET_DISC_DEVICE POST_BUILD
+  COMMAND ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/TEST_TARGET_DISC_DEVICE
+)

extras/test/src/test_discovered_device/test_discovered_device.cpp

@@ -0,0 +1,52 @@
+/*
+  This file is part of the ArduinoBLE library.
+  Copyright (c) 2018 Arduino SA. All rights reserved.
+
+  This library is free software; you can redistribute it and/or
+  modify it under the terms of the GNU Lesser General Public
+  License as published by the Free Software Foundation; either
+  version 2.1 of the License, or (at your option) any later version.
+
+  This library is distributed in the hope that it will be useful,
+  but WITHOUT ANY WARRANTY; without even the implied warranty of
+  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+  Lesser General Public License for more details.
+
+  You should have received a copy of the GNU Lesser General Public
+  License along with this library; if not, write to the Free Software
+  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+*/
+
+#include <catch.hpp>
+
+#define private public
+#define protected public
+#include "BLEDevice.h"
+
+SCENARIO("BLE discovered device test", "[ArduinoBLE::BLEDevice]")
+{
+
+  WHEN("Retrieve local name from advertisement packet")
+  {
+    // Mocking advertisement packet
+    uint8_t advType = 0x03;
+    uint8_t eirLength = 6;
+    uint8_t eirData[] = {0x05, 0x09, 't', 'e', 's', 't'};
+    uint8_t rssi = 0;
+
+    // Expected results
+    String goldenName = "test";
+
+    // Simulate device discovery
+    BLEDevice device = BLEDevice();
+    device.setAdvertisingData(eirLength, eirData, rssi); 
+
+    bool hasName = device.hasLocalName();
+    REQUIRE(hasName);
+
+    String name = device.localName();
+    REQUIRE(goldenName == name);
+
+  }
+
+}

src/local/BLELocalDevice.cpp

@@ -343,5 +343,7 @@ void BLELocalDevice::noDebug()
   HCI.noDebug();
 }
 
+#if !defined(FAKE_BLELOCALDEVICE)
 BLELocalDevice BLEObj;
 BLELocalDevice& BLE = BLEObj;
+#endif

src/utility/ATT.cpp

@@ -1687,5 +1687,7 @@ void ATTClass::writeCmd(uint16_t connectionHandle, uint16_t handle, const uint8_
   sendReq(connectionHandle, &writeReq, 3 + dataLen, NULL);
 }
 
+#if !defined(FAKE_ATT)
 ATTClass ATTObj;
 ATTClass& ATT = ATTObj;
+#endif

src/utility/GAP.cpp

@@ -258,5 +258,7 @@ bool GAPClass::matchesScanFilter(const BLEDevice& device)
   return true;
 }
 
+#if !defined(FAKE_GAP)
 GAPClass GAPObj;
 GAPClass& GAP = GAPObj;
+#endif

src/utility/GATT.cpp

@@ -172,5 +172,7 @@ void GATTClass::clearAttributes()
   _attributes.clear();
 }
 
+#if !defined(FAKE_GATT)
 GATTClass GATTObj;
 GATTClass& GATT = GATTObj;
+#endif

src/utility/HCI.cpp

@@ -686,5 +686,7 @@ void HCIClass::dumpPkt(const char* prefix, uint8_t plen, uint8_t pdata[])
   }
 }
 
+#if !defined(FAKE_HCI)
 HCIClass HCIObj;
 HCIClass& HCI = HCIObj;
+#endif

src/utility/L2CAPSignaling.cpp

@@ -146,5 +146,7 @@ void L2CAPSignalingClass::connectionParameterUpdateResponse(uint16_t /*handle*/,
 {
 }
 
+#if !defined(FAKE_L2CAP)
 L2CAPSignalingClass L2CAPSignalingObj;
 L2CAPSignalingClass& L2CAPSignaling = L2CAPSignalingObj;
+#endif