CheckVariant: add test status

Signed-off-by: Alexandre Bourdiol <[email protected]>

Author: ABOSTM

examples/NonReg/CheckVariant/CheckVariant.ino

@@ -1,3 +1,7 @@
+/*
+ * This sketch check, digital and analog pins defined in the variant
+ */
+
 #include "utils.h"
 
 #define PORTx(pn)   (char)('A' + STM_PORT(pn))
@@ -37,16 +41,41 @@ void setup() {
 }
 
 void loop() {
+
+  bool testPassed = true;
+  String testStatus;
+  uint32_t blinkDelay;
+
+  Serial.println("#####");
   Serial.printf("NUM_DIGITAL_PINS = %i\n", NUM_DIGITAL_PINS);
   Serial.printf("NUM_ANALOG_INPUTS = %i\n", NUM_ANALOG_INPUTS);
 
-  checkDigitalPins();
-  checkAnalogPins();
+ /* Run the different tests */
+  if (!checkDigitalPins()) {
+    testPassed = false;
+  }
+  if (!checkAnalogPins()) {
+    testPassed = false;
+  }
+
+  /* Display test result */
+  if (testPassed) {
+    testStatus = "PASSED";
+    blinkDelay = 1000;
+  } else {
+    testStatus = "FAILED";
+    blinkDelay = 200;
+  }
+  Serial.println("");
+  Serial.println("########################################");
+  Serial.printf("#### Test %s\n", testStatus.c_str());
+  Serial.println("########################################");
 
+  /* Blink Led forever, slowly for test passed, and quickly for test failed */
   while (1) {
     digitalWrite(LED_BUILTIN, HIGH);   // turn the LED on (HIGH is the voltage level)
-    delay(1000);                       // wait for a second
+    delay(blinkDelay);
     digitalWrite(LED_BUILTIN, LOW);    // turn the LED off by making the voltage LOW
-    delay(1000);                       // wait for a second
+    delay(blinkDelay);
   }
 }

examples/NonReg/CheckVariant/analogPinsTest.ino

@@ -1,5 +1,12 @@
+/*
+ * Check Analog pins
+ * Return true in case of test passed
+ * Return false in case of test failed
+ */
+bool checkAnalogPins(void) {
+  bool testPassed = true;
 
-void checkAnalogPins(void) {
+  Serial.println("#####");
   Serial.println("Checking analog pins definition...");
 
   for ( uint32_t i = 0; i < (NUM_ANALOG_INPUTS); i++) {
@@ -26,35 +33,17 @@ void checkAnalogPins(void) {
 
       res |= 8;
     }
-    /*
-       pname: Pin of type PinName (PY_n)
-       asPN: true display as a PinName, false as a pin number (PYn)
-       val: display value or not
-       ln: carriage return or not
-    */
+
     if (res) {
       Serial.printf("A%i defined as %i with pin name: ", i, A0 + i);
       printPinName(pn_aTpn_Ax, true, true, false);
       Serial.print(" and pin number: ");
       printPinName(pn_aTpn_Ax, false, true, false);
       Serial.printf(" --> %i\n", res);
       Serial.printf(" --> digitalPinToAnalogInput(%i) = %i\n", pinnum_aTD_i, digitalPinToAnalogInput(pinnum_aTD_i));
-      
-
-      //      Serial.print("\tPin name ");
-      //      printPinName(pn_Ax, true, true, false);
-      //      Serial.print(" have to be indexed higher than NUM_ANALOG_INPUTS (");
-      //      Serial.print(NUM_ANALOG_INPUTS);
-      //      Serial.println(") to be able to use:");
-      //      PinName pn_Ax_analog = analogInputToPinName(pinNametoDigitalPin(pn_Ax));
-      //      Serial.print("\tAnalogRead(");
-      //      printPinName(pn_Ax, false, false, false);
-      //      Serial.print(") -->  which currently use pin name: ");
-      //      printPinName(pn_Ax_analog, true, true, false);
-      //      Serial.print(" and pin number: ");
-      //      printPinName(pn_Ax_analog, false, true, true);
+      testPassed = false;
     }
   }
   Serial.println("End check analog pins");
-  Serial.println("#####");
+  return testPassed;
 }