fix: apply ShellCheck and shfmt

Signed-off-by: Frederic Pillon <[email protected]>

Author: fpistm

run_arduino_gen.sh

@@ -20,7 +20,7 @@ ELF_BINARY=""
 
 autodetect_board() {
   if [ ! -d /proc/device-tree/ ]; then
-    echo "Proc Device tree are not available, Could not detect on which board we are" > /dev/kmsg
+    echo "Proc Device tree are not available, Could not detect on which board we are" >/dev/kmsg
     exit 1
   fi
 
@@ -34,10 +34,10 @@ autodetect_board() {
   elif grep -q "stm32mp157" /proc/device-tree/compatible; then
     BOARD="STM32MP157_GENERIC"
   else
-    echo "Board is not an STM32MP157 BOARD" > /dev/kmsg
+    echo "Board is not an STM32MP157 BOARD" >/dev/kmsg
     exit 1
   fi
-  echo "Board is $BOARD" > /dev/kmsg
+  echo "Board is $BOARD" >/dev/kmsg
 }
 
 firmware_load() {
@@ -46,42 +46,42 @@ firmware_load() {
     exit 1
   fi
 
-  if (echo "$ELF_HASH $ELF_INSTALL_PATH" | sha256sum --status -c - 2> /dev/null); then
+  if (echo "$ELF_HASH $ELF_INSTALL_PATH" | sha256sum --status -c - 2>/dev/null); then
     # The same firmware already exists, skip this step
     echo "The same firmware is already installed. Starting..."
     return 0
   fi
 
   # Decode base64-encoded binary to a temp directory and check hash
   tmp_elf_file="/tmp/$ELF_NAME"
-  if which uudecode > /dev/null 2>&1; then
-    printf "%s" "$ELF_BINARY" | uudecode -o /dev/stdout | gzip -d > "$tmp_elf_file"
+  if which uudecode >/dev/null 2>&1; then
+    printf "%s" "$ELF_BINARY" | uudecode -o /dev/stdout | gzip -d >"$tmp_elf_file"
   else
-    printf "%s" "$ELF_BINARY" | tail -n +2 | base64 -d - 2> /dev/null | gzip -d > "$tmp_elf_file"
+    printf "%s" "$ELF_BINARY" | tail -n +2 | base64 -d - 2>/dev/null | gzip -d >"$tmp_elf_file"
   fi
   echo "$ELF_HASH $tmp_elf_file" | sha256sum --status -c -
 
   # Copy elf into /lib/firmware
   mv $tmp_elf_file $ELF_INSTALL_PATH
-  echo "Arduino: Executable created: $ELF_INSTALL_PATH" > /dev/kmsg
+  echo "Arduino: Executable created: $ELF_INSTALL_PATH" >/dev/kmsg
 }
 
 firmware_start() {
   # Change the name of the firmware
-  printf arduino.ino.elf > $REMOTEPROC_DIR/firmware
+  printf arduino.ino.elf >$REMOTEPROC_DIR/firmware
 
   # Change path to found firmware
   #printf /home/root >/sys/module/firmware_class/parameters/path
 
   # Restart firmware
-  echo "Arduino: Starting $ELF_INSTALL_PATH" > /dev/kmsg
-  echo start > $REMOTEPROC_DIR/state 2> /dev/null || true
+  echo "Arduino: Starting $ELF_INSTALL_PATH" >/dev/kmsg
+  echo start >$REMOTEPROC_DIR/state 2>/dev/null || true
 }
 
 firmware_stop() {
   # Stop the firmware
-  echo "Arduino: Stopping $ELF_INSTALL_PATH" > /dev/kmsg
-  echo stop > $REMOTEPROC_DIR/state 2> /dev/null || true
+  echo "Arduino: Stopping $ELF_INSTALL_PATH" >/dev/kmsg
+  echo stop >$REMOTEPROC_DIR/state 2>/dev/null || true
 }
 
 generate_packaged_script() {
@@ -96,25 +96,25 @@ generate_packaged_script() {
   # Generate a copy of this script with a self-contained elf binary and its hash
   # The elf binary is gzip'ed, making its size to 1/6, and then Base64-encoded
   # using uuencode.
-  head -n "$(grep -n "{%" "$this_script" | cut -d: -f1 | head -n 1)" "$this_script" > "$output_script"
-  echo "ELF_HASH='$(sha256sum "$elf_path" | cut -d' ' -f1)'" >> "$output_script"
-  printf "ELF_BINARY='" >> "$output_script"
-  if which uuencode > /dev/null 2>&1; then
-    gzip -c "$elf_path" | uuencode -m $ELF_NAME >> "$output_script"
+  head -n "$(grep -n "{%" "$this_script" | cut -d: -f1 | head -n 1)" "$this_script" >"$output_script"
+  echo "ELF_HASH='$(sha256sum "$elf_path" | cut -d' ' -f1)'" >>"$output_script"
+  printf "ELF_BINARY='" >>"$output_script"
+  if which uuencode >/dev/null 2>&1; then
+    gzip -c "$elf_path" | uuencode -m $ELF_NAME >>"$output_script"
   else
-    echo "begin-base64 644 $ELF_NAME" >> "$output_script"
-    gzip -c "$elf_path" | base64 >> "$output_script"
+    echo "begin-base64 644 $ELF_NAME" >>"$output_script"
+    gzip -c "$elf_path" | base64 >>"$output_script"
   fi
-  echo "'" >> "$output_script"
-  tail -n +"$(grep -n "%}" "$this_script" | cut -d: -f1 | head -n 1)" "$this_script" >> "$output_script"
-  dos2unix "$output_script" 2> /dev/null
+  echo "'" >>"$output_script"
+  tail -n +"$(grep -n "%}" "$this_script" | cut -d: -f1 | head -n 1)" "$this_script" >>"$output_script"
+  dos2unix "$output_script" 2>/dev/null
 }
 
 systemd_install() {
   mkdir -p "$(dirname $INSTALL_PATH)"
   cp "$0" "$INSTALL_PATH"
   echo "File created: $INSTALL_PATH"
-  cat > "$SYSTEMD_SERVICE_PATH" << EOF
+  cat >"$SYSTEMD_SERVICE_PATH" <<EOF
 [Unit]
 Description=Run Arduino firmware via remoteproc
 After=systemd-modules-load.service
@@ -161,7 +161,7 @@ try_send() {
   # Linux host must send any dummy data first to finish initialization of rpmsg
   # on the coprocessor side. This message should be discarded.
   # See: https://github.com/OpenAMP/open-amp/issues/182
-  printf "DUMMY" > $RPMSG_DIR
+  printf "DUMMY" >$RPMSG_DIR
   echo "Virtual serial $RPMSG_DIR connection established."
 }
 
@@ -203,7 +203,7 @@ case "$1" in
     ;;
   send-msg)
     autodetect_board
-    echo "${@:2}" > $RPMSG_DIR
+    echo "${@}" | cut -c 3- >$RPMSG_DIR
     ;;
   send-file)
     autodetect_board