Skip to content

Add STM32F446VE controller board #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2019
Merged

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented May 17, 2019

Replace #522
From @petervanaken
Summary

This PR implements the following : Introduction of a new board called VAkE v1.0. This board is based upon the STM32F446VE. It can be used as 3D printer / CNC controller board with versatile stepper configuration.
All comments are welcome.
Please find more info about the VAkE PCB : https://www.facebook.com/pages/category/Product-Service/VAkE-Board-2290066274575218/
Cheers,
Peter

Signed-off-by: Peter Van Aken <[email protected]>
@fpistm fpistm added the new variant Add support of new bard label May 17, 2019
@fpistm
Copy link
Member Author

fpistm commented May 17, 2019

@petervanaken
do not hesitate to comment and give feedback on this PR.
Mainly about boards.txt and name used

@fpistm fpistm added the waiting feedback Further information is required label May 17, 2019
@petervanaken
Copy link

I've tested the PR on target and everything looks fine to me.
What else needs to be done to merge with the master ?
Cheers,
Peter

@fpistm
Copy link
Member Author

fpistm commented May 27, 2019

Hi @petervanaken
The main things is the naming in the menu. If you are agreed then I could merge it.

@petervanaken
Copy link

Yes, the naming looks fine.
Cheers,
Peter

@fpistm fpistm removed Review on going waiting feedback Further information is required labels May 27, 2019
@fpistm fpistm added this to the 1.6.0 milestone May 27, 2019
@fpistm fpistm self-assigned this May 27, 2019
@fpistm fpistm merged commit d285074 into stm32duino:master May 27, 2019
@fpistm fpistm deleted the PR-522-reviewed branch May 27, 2019 14:23
@fpistm
Copy link
Member Author

fpistm commented May 27, 2019

@petervanaken
FYI, I've referenced the board in the README.md

@petervanaken
Copy link

Great :-D , thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new variant Add support of new bard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants