Skip to content

Add RUMBA32 3D Printer Control Board #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 15, 2019
Merged

Add RUMBA32 3D Printer Control Board #390

merged 6 commits into from
Jan 15, 2019

Conversation

chrissbarr
Copy link
Contributor

Requesting to add a board definition for the Aus3D RUMBA32 3D printer control board I'm currently working on (details here).

Things are fairly polished up on the hardware side, and we're looking at offering these for sale in the next 5-6 weeks - so my hope is we can get this merged in before the next release (not sure how far off that is).

I believe these should be the minimum necessary changes to add the variant, but am open to any and all feedback, and can make any changes suggested.

Thanks!

@fpistm fpistm self-requested a review December 14, 2018 05:59
@fpistm fpistm added the new variant Add support of new bard label Dec 14, 2018
@fpistm fpistm added this to the 1.5.0 milestone Dec 14, 2018
@fpistm
Copy link
Member

fpistm commented Dec 14, 2018

Thanks, I will review it next week. I will review maylan at the same time #382

@chrissbarr
Copy link
Contributor Author

Thank you! Let me know if there's anything I can do to help with the process.

fpistm
fpistm requested changes Dec 21, 2018
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall PR is well formed.
Please, see my comments/questions below.
Thanks in advance

@fpistm fpistm added the waiting feedback Further information is required label Dec 21, 2018
@chrissbarr
Copy link
Contributor Author

Thanks for looking it over! I will double-check and make those changes tomorrow.

@fpistm
Copy link
Member

fpistm commented Dec 21, 2018

Welcome. Dont' worry. You have time. This is the christmas hollydays so I will be less present until 2019. 😉🎄

@chrissbarr
Copy link
Contributor Author

Things should now be up to date with your comments. I merged your USB branch in for testing and it seemed to work correctly - I only did one quick test sketch, but so far so good!

I probably won't be doing much with this for another week or two while I'm waiting on a new hardware revision to show up, so there's no rush to get it merged. Hope you had a great Christmas, and all the best for New Years!

fpistm
fpistm requested changes Jan 14, 2019
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.
Only one things to do and then I guess it will be ready for merge.

@fpistm
Copy link
Member

fpistm commented Jan 14, 2019

Hum, I had several trouble with this PR as it contains several commits not related to RUMBA32 addition.
I guess you submit this PR in a branch including a previous version of the USB implementation PR.
Could you rebase on top and clean all not related to RUMBA32 ?

You should have only these 4 commits:

  • USB-related fixes
  • Fix analog input count
  • Update USB-related stuff
  • Add RUMBA32 Variant

@chrissbarr
Copy link
Contributor Author

Huh. I'm not sure why those other commits are in there - I don't remember seeing them previously, and did not deliberately add them, but must have somehow.

I've reset the branch to before my most recent commit, and that seems to have cleared them - so somehow I must have pulled those changes in there.

It looks correct to me now - if you want to take another look at it, that would be awesome.

@fpistm fpistm merged commit a7a6d70 into stm32duino:master Jan 15, 2019
@fpistm fpistm removed the waiting feedback Further information is required label Jan 15, 2019
@fpistm
Copy link
Member

fpistm commented Jan 15, 2019

Thanks. I've fix the last conflict then it is ok.

benwaffle pushed a commit to benwaffle/Arduino_Core_STM32 that referenced this pull request Apr 10, 2019
@chrissbarr @fpistm
Add RUMBA32 3D Printer Control Board (stm32duino#390)
3f11561 
Aus3D RUMBA32 3D printer control board
See https://github.com/Aus3D/RUMBA32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm requested changes

Assignees

@chrissbarr chrissbarr

Labels
new variant Add support of new bard
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@chrissbarr @fpistm