Skip to content

Disabled Core callback feature #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2017
Merged

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Nov 9, 2017

STM32Ethernet do not use anymore this feature.
Disabled it to avoid unuseful call in the main while{}.
Define CORE_CALLBACK allow to enable it.

STM32Ethernet do not use anymore this feature.
Disabled it to avoid unuseful call in the main while{}.
Define CORE_CALLBACK allow to enable it.

Signed-off-by: Frederic.Pillon <[email protected]>
@fpistm fpistm requested a review from a user November 9, 2017 08:39
@fpistm fpistm added the enhancement New feature or request label Nov 9, 2017
@fpistm fpistm added this to the Next release milestone Nov 9, 2017
@ghost
Copy link

ghost commented Nov 9, 2017

Where will CORE_CALLBACK be defined?

@fpistm
Copy link
Member Author

fpistm commented Nov 10, 2017

Currently anywhere.
It could be documented for the #41.
Goal is only to disable it to avoid call in the loop.

@fpistm fpistm merged commit aac2385 into stm32duino:master Nov 10, 2017
@fpistm fpistm deleted the corecallback branch November 10, 2017 10:19
benwaffle pushed a commit to benwaffle/Arduino_Core_STM32 that referenced this pull request Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant