-
Notifications
You must be signed in to change notification settings - Fork 1k
Move Arduino libraries dedicated for STM32 core into single repo #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
in my opinion open a repo for every library it is dispersive, For example it is enough call the Wire library "Wire(STM32)" All the library that do not have specific modification for STM32, for example firmata ? can remain on his repo, and completely deleted from here |
Firmata need an update, I will do the pull request on the official repo to add support for the STM32 then I will delete it from the core. Open a repo for each specific library allow to use Library manager from Arduino. Having all libraries in the core is not a good option. Many libraries are specific to a board (ex: ethernet is available only on few boards (F429zi, Disco746)) so this will increase core size while user will not use it. If user wants then he will have the possibility to install it. |
It is true that you do not have ide library update, but if the lib is in the core it will updated when update the core by board manager, may be some modification on a lib needed by a core modification, in this case you can go out of sync. Very big core peoject, like ESP, have it's modified lib inside the core. Another useful think is that when the libs is in the core you can immediately view how many lib you have so what you can do, without search for a lib without cechk if it is compatible. But i know that also the separated github have advantage, like tracking of issue directly to a lib repo, instead of all togheter on the core repo |
PR for Firmata merged in official repo. |
Release of Firmata 2.5.7 available. |
TFT: pull request done: arduino-libraries/TFT#11 |
Another libraries could be:
|
Right @straccio, |
Ok, Sorry! |
No worries ;) |
Purpose of this issue is to move Arduino libraries dedicated for STM32 core in separate repository.
I talk about libraries dedicated to hardware features: on board SD, Ethernet, LCD….
For purely software libraries, pull request should be done on dedicated github (ex: firmata,…) as far as possible else a repo could be created.
The core should only embed those for common hardware support (Wire/SPI/…).
As specified here:
https://github.com/arduino/Arduino/wiki/Library-Manager-FAQ#how-can-i-add-my-library-to-library-manager
So one library == a single repo.
ARDUINO_ARCH_STM32 must be used as differentiator.
This is a first approach any comments/suggestions are welcome. Mainly on repo name or way of working.
The text was updated successfully, but these errors were encountered: