Skip to content

STM32L0xx_HAL_CONF.h defines not correctly supported in core. #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
disk91 opened this issue Sep 4, 2018 · 2 comments
Closed

STM32L0xx_HAL_CONF.h defines not correctly supported in core. #314

disk91 opened this issue Sep 4, 2018 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@disk91
Copy link

disk91 commented Sep 4, 2018

When you want to make your own board definition and modify the STM32L0xx_HAL_CONF.h to remove unsupported or unexisting feature it creates dependency failure. As an exemple if you try to compile w/o SPI
//#define HAL_SPI_MODULE_ENABLED
you get:

in file included from /Users/paul/Documents/Arduino/hardware/stm32/1.3.0/cores/arduino/board.h:19:0,
from /Users/paul/Documents/Arduino/hardware/stm32/1.3.0/cores/arduino/wiring.h:41,
from /Users/paul/Documents/Arduino/hardware/stm32/1.3.0/cores/arduino/Arduino.h:32,
from /var/folders/pz/tbk987c56x3791b90cqz65n80000gn/T/arduino_build_470787/sketch/Blink.ino.cpp:1:
/Users/paul/Documents/Arduino/hardware/stm32/1.3.0/cores/arduino/stm32/spi_com.h:53:5: error: 'SPI_HandleTypeDef' does not name a type
SPI_HandleTypeDef handle;

Basically spi_com.h should not be refered if the SPI module is unactivated.
We have the same issue with I2C.

ADC, RCC, we can't compile w/o these Modules too.

@fpistm
Copy link
Member

fpistm commented Sep 5, 2018

Hi @disk91,
Disable HAL feature will be covered by #228.
All features linked to a built-in library, if not included, code is not embedded but it still the related PinMap_ arrays
The only one which will be hard to fully removed will be RCC as it is requested to configure and enable clocks. LL have to be used to remove it.
Any contribution are welcome, if you made the job for one feature do not hesitate to do a PR. ;)

@fpistm fpistm added the duplicate This issue or pull request already exists label Sep 14, 2018
@fpistm
Copy link
Member

fpistm commented Oct 12, 2018

Added RCC to the list in #228.
Closed this one as it is a duplicated issue

@fpistm fpistm closed this as completed Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants