Skip to content

serialEventRun() has typo calls serialEvent() for all ports #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RickKimball opened this issue Jun 10, 2017 · 1 comment
Closed

serialEventRun() has typo calls serialEvent() for all ports #22

RickKimball opened this issue Jun 10, 2017 · 1 comment
Assignees
Labels
bug 🐛 Something isn't working

Comments

@RickKimball
Copy link
Contributor

RickKimball commented Jun 10, 2017

https://github.com/stm32duino/Arduino_Core_STM32/blob/master/variants/NUCLEO_F091RC/variant.cpp#L111-L112 is an example however it appears that is a problem in multiple variant.cpp files.

void serialEventRun(void)
{
  if (Serial.available()) serialEvent();
  if (Serial1.available()) serialEvent();
  if (Serial2.available()) serialEvent();
}

This should probably be

void serialEventRun(void)
{
  if (Serial.available()) serialEvent();
  if (Serial1.available()) serialEvent1();
  if (Serial2.available()) serialEvent2();
}
@fpistm fpistm added the bug 🐛 Something isn't working label Jun 11, 2017
@fpistm fpistm self-assigned this Jun 12, 2017
@fpistm fpistm closed this as completed in b30145b Jun 12, 2017
@davemaster
Copy link

Just put this;

in loop or whatever your function is,

if (Serial.available>())
serialEvent();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants