fix(uart): ensure debug uart is ready before send

Like state is ready not need to loop on the blocking
HAL_UART_Transmit(). If not ok it can be HAL_ERROR or HAL_TIMEOUT.
Moreover, it avoid to disable the U(S)ART IRQ which prevent to
receive data.

Fixes #1789

Signed-off-by: Frederic Pillon <[email protected]>

Author: fpistm

Diff for: libraries/SrcWrapper/src/stm32/uart.c

@@ -705,6 +705,7 @@ void uart_debug_init(void)
 size_t uart_debug_write(uint8_t *data, uint32_t size)
 {
   uint32_t tickstart = HAL_GetTick();
+  serial_t *obj = NULL;
 
   if (serial_debug.index >= UART_NUM) {
     if (DEBUG_UART == NP) {
@@ -726,26 +727,22 @@ size_t uart_debug_write(uint8_t *data, uint32_t size)
       if (serial_debug.index >= UART_NUM) {
         return 0;
       }
-    } else {
-      serial_t *obj = get_serial_obj(uart_handlers[serial_debug.index]);
-      if (obj) {
-        serial_debug.irq = obj->irq;
-      } else {
-        return 0;
-      }
     }
   }
+  obj = get_serial_obj(uart_handlers[serial_debug.index]);
+  if (!obj) {
+    return 0;
+  }
 
-  HAL_NVIC_DisableIRQ(serial_debug.irq);
-
-  while (HAL_UART_Transmit(uart_handlers[serial_debug.index], data, size, TX_TIMEOUT) != HAL_OK) {
-    if ((HAL_GetTick() - tickstart) >=  TX_TIMEOUT) {
-      size = 0;
-      break;
+  while (serial_tx_active(obj)) {
+    if ((HAL_GetTick() - tickstart) >= TX_TIMEOUT) {
+      return 0;
     }
   }
 
-  HAL_NVIC_EnableIRQ(serial_debug.irq);
+  if (HAL_UART_Transmit(&(obj->handle), data, size, TX_TIMEOUT) != HAL_OK) {
+    size = 0;
+  }
 
   return size;
 }