fix: error and warning raised by flake8

Signed-off-by: Frederic Pillon <[email protected]>
Signed-off-by: Alexis Masson <[email protected]>

Author: fpistm

Diff for: cmake/scripts/.flake8

@@ -0,0 +1,2 @@
+[flake8]
+max-line-length = 88

Diff for: cmake/scripts/ccwrapper.py

@@ -22,7 +22,7 @@
 
 shargs = parser.parse_args()
 
-logline = re.compile("^\.* .+$")  # a series of dots, a space, a filename
+logline = re.compile(r"^\.* .+$")  # a series of dots, a space, a filename
 
 
 proc = subprocess.run(shargs.cmd, capture_output=True, encoding="ascii")

Diff for: cmake/scripts/cmake_core.py

@@ -1,10 +1,9 @@
 #!/usr/bin/env python3
 
 import argparse
-import sys
 from pathlib import Path
 from jinja2 import Environment, FileSystemLoader
-from cmake_gen import *
+from cmake_gen import config_for_bareflat, render
 
 script_path = Path(__file__).parent.resolve()
 

Diff for: cmake/scripts/cmake_easy_setup.py

@@ -46,7 +46,8 @@
     print(
         """
     Warning: you did not specify which board you were targeting;
-    please review the generated CMakeLists.txt to remove the placeholder value before calling `cmake`.
+    please review the generated CMakeLists.txt to remove the placeholder
+    value before calling `cmake`.
     """
     )
 
@@ -121,8 +122,20 @@ def get_boards(boardstxt):
         libpaths[line["location"]] = pathlib.Path(line["dir"])
 
 # platform lib path is already known, obviously, since that's where this script resides
-userlibs = pathlib.Path(libpaths["user"]).resolve()
-libs = [u.name for u in userlibs.iterdir() if u.is_dir()]
+userlibs = pathlib.Path(libpaths["user"])
+if userlibs.exists():
+    userlibs = userlibs.resolve()
+    libs = [u.name for u in userlibs.iterdir() if u.is_dir()]
+else:
+    print(
+        f"""Warning: Cannot find {userlibs}.
+    This has likely to do with your arduino-cli configuration.
+    Please refer to the following link for setup details:
+    https://arduino.github.io/arduino-cli/0.26/getting-started/#create-a-configuration-file
+    """
+    )
+    libs = list()
+
 corepath = pathlib.Path(__file__).parent.parent.parent.resolve()
 
 j2_env = Environment(

Diff for: cmake/scripts/cmake_libs.py

@@ -3,7 +3,7 @@
 import argparse
 from pathlib import Path
 from jinja2 import Environment, FileSystemLoader
-from cmake_gen import *
+from cmake_gen import autoconfig, render
 
 script_path = Path(__file__).parent.resolve()
 

Diff for: cmake/scripts/cmake_updater_hook.py

@@ -1,7 +1,8 @@
 #!/usr/bin/env python3
 
 """
-This file centralizes all the operations needed to regenerate the CMakeLists.txt scattered along this repo.
+This file centralizes all the operations needed to regenerate the CMakeLists.txt
+scattered along this repo.
 Hint: it would be a good practice to run it before committing...
 """
 

Diff for: cmake/scripts/cmake_variant.py

@@ -3,7 +3,7 @@
 import argparse
 from pathlib import Path
 from jinja2 import Environment, FileSystemLoader
-from cmake_gen import *
+from cmake_gen import config_for_bareflat, render
 
 script_path = Path(__file__).parent.resolve()
 

Diff for: cmake/scripts/generate_header.py

@@ -2,7 +2,6 @@
 
 import argparse
 import pathlib
-import subprocess
 
 parser = argparse.ArgumentParser()
 parser.add_argument(

Diff for: cmake/scripts/parse_boards.py

@@ -25,7 +25,7 @@ def __getattr__(self, attr):
         return self.__getitem__(attr)
 
     def __setattr__(self, attr, val):
-        return self.__setitem__(item, attr)
+        return self.__setitem__(val, attr)
 
     def set_default_entries(self, mothercfg):
         for k, v in mothercfg.items():
@@ -51,9 +51,13 @@ def evaluate_entries(self, wrt=None):
                 self[k].evaluate_entries(wrt)
 
 
+def default_reject(x):
+    return False
+
+
 def parse_file(infile, reject=None):
     if reject is None:
-        reject = lambda x: False
+        reject = default_reject
 
     config = Configuration()
 

Diff for: cmake/scripts/sizereport.py

@@ -49,7 +49,10 @@
 
 print(
     f"""
-Sketch uses {allsz} bytes ({allsz/shargs.progmem:.0%}) of program storage space. Maximum is {shargs.progmem} bytes.
-Global variables use {datasz} bytes ({datasz/shargs.datamem:.0%}) of dynamic memory, leaving {shargs.datamem-datasz} bytes for local variables. Maximum is {shargs.datamem} bytes.
+Sketch uses {allsz} bytes ({allsz/shargs.progmem:.0%}) of program storage space. \
+Maximum is {shargs.progmem} bytes.
+Global variables use {datasz} bytes ({datasz/shargs.datamem:.0%}) of dynamic memory, \
+leaving {shargs.datamem-datasz} bytes for local variables. \
+Maximum is {shargs.datamem} bytes.
 """
 )

Diff for: cmake/scripts/syms.py

@@ -43,15 +43,14 @@ def parse_file(mapf):
                 demander, sym = line.strip().rsplit(") (", 1)
                 demander = demander + ")"
                 sym = "(" + sym
-            except:
+            except Exception:
                 continue
         else:
             provider = line.strip()
 
         if provider and demander and sym:
-            objdemander = demander.rsplit("/", 1)[
-                1
-            ]  # .split("(")[0] gets the lib ; without this you get the obj
+            # .split("(")[0] gets the lib ; without this you get the obj
+            objdemander = demander.rsplit("/", 1)[1]
             objprovider = provider.rsplit("/", 1)[1]
             libdemander = objdemander.split("(")[0]
             libprovider = objprovider.split("(")[0]

Diff for: cmake/scripts/update_boarddb.py

@@ -16,8 +16,10 @@ def get_fpconf(config):
 
 def boardstxt_filter(key):
     # Remove menu entry labels
-    # In our data model, they conflict with the actual configuration they are associated to
-    # i.e. Nucleo_144.menu.pnum.NUCLEO_F207ZG would be both a string ("Nucleo F207ZG")
+    # In our data model, they conflict with the actual configuration
+    # they are associated to
+    # i.e. Nucleo_144.menu.pnum.NUCLEO_F207ZG would be both
+    # a string ("Nucleo F207ZG")
     # and a dict (.build.variant_h=..., .upload.maximum_size=...)
 
     if key[0] == "menu":
@@ -120,7 +122,8 @@ def regenerate_template(config, infile, outfile):
         famcfg.set_default_entries(platformtxt_cfg)
 
         inherit_fam = famcfg.copy()
-        # shallow copy; we don't want to impact famcfg so we have to copy before edit/del
+        # shallow copy;
+        # we don't want to impact famcfg so we have to copy before edit/del
         inherit_fam["menu"] = inherit_fam["menu"].copy()
         # del what you iterate over (otherwise you get infinite nesting)
         del inherit_fam["menu"]["pnum"]
@@ -142,7 +145,8 @@ def regenerate_template(config, infile, outfile):
                     labelcfg.set_default_entries(inherit_board)
                     labelcfg.evaluate_entries()
 
-            # base config won't manage all the board features, we thus have to mask them out
+            # base config won't manage all the board features,
+            # we thus have to mask them out
             for feat in BOARD_FEATURES:
                 boardcfg.build[feat] = ""