Add digitalPinIsValid() function

Handle if pin is valid (!=NC)
Used for firmata.

Signed-off-by: Frederic.Pillon <[email protected]>

Author: fpistm

Diff for: cores/arduino/pins_arduino.h

@@ -65,6 +65,8 @@ uint32_t pinNametoDigitalPin(PinName p);
 #define digitalPinToPort(p)        ( get_GPIO_Port(digitalPinToPinName(p)) )
 #define digitalPinToBitMask(p)     ( STM_GPIO_PIN(digitalPinToPinName(p)) )
 
+#define digitalPinIsValid(p)       (digitalPinToPinName(p) != NC)
+
 #ifdef __cplusplus
 }
 #endif

Diff for: libraries/Firmata/Boards.h

@@ -771,7 +771,7 @@ writePort(port, value, bitmask):  Write an 8 bit port.
 #define TOTAL_PORTS             MAX_NB_PORT
 #define VERSION_BLINK_PIN       LED_BUILTIN
 // PIN_SERIALY_RX/TX defined in the variant.h
-#define IS_PIN_DIGITAL(p)       ((p != PIN_SERIAL_RX) && (p != PIN_SERIAL_TX) && (p < TOTAL_PINS))
+#define IS_PIN_DIGITAL(p)       (digitalPinIsValid(p) && (p != PIN_SERIAL_RX) && (p != PIN_SERIAL_TX))
 #define IS_PIN_ANALOG(p)        ((p) >= A0 && (p) < AEND)
 #define IS_PIN_PWM(p)           digitalPinHasPWM(p)
 #define IS_PIN_SERVO(p)         IS_PIN_DIGITAL(p)