Merge pull request #71 from cparata/master

fpistm · web-flow · commit 078f1f53a8af · 2017-08-03T12:09:03.000+02:00
Fix possible issue on serial ports
diff --git a/cores/arduino/HardwareSerial.cpp b/cores/arduino/HardwareSerial.cpp
@@ -70,14 +70,13 @@ int HardwareSerial::_tx_complete_irq(serial_t* obj)
 {
   // If interrupts are enabled, there must be more data in the output
   // buffer. Send the next byte
-  unsigned char c = obj->tx_buff[obj->tx_tail];
   obj->tx_tail = (obj->tx_tail + 1) % SERIAL_TX_BUFFER_SIZE;
 
   if (obj->tx_head == obj->tx_tail) {
     return -1;
   }
 
-  return c;
+  return 0;
 }
 
 // Public Methods //////////////////////////////////////////////////////////////

Original file line number	Diff line number	Diff line change
`@@ -70,14 +70,13 @@ int HardwareSerial::_tx_complete_irq(serial_t* obj)`
`70`	`70`	`{`
`71`	`71`	`// If interrupts are enabled, there must be more data in the output`
`72`	`72`	`// buffer. Send the next byte`
`73`		`- unsigned char c = obj->tx_buff[obj->tx_tail];`
`74`	`73`	`obj->tx_tail = (obj->tx_tail + 1) % SERIAL_TX_BUFFER_SIZE;`
`75`	`74`
`76`	`75`	`if (obj->tx_head == obj->tx_tail) {`
`77`	`76`	`return -1;`
`78`	`77`	`}`
`79`	`78`
`80`		`- return c;`
	`79`	`+ return 0;`
`81`	`80`	`}`
`82`	`81`
`83`	`82`	`// Public Methods //////////////////////////////////////////////////////////////`