ci: use nvim-typecheck-action v2

Author: stevearc

.github/workflows/tests.yml

@@ -42,7 +42,7 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v4
-      - uses: stevearc/nvim-typecheck-action@v1
+      - uses: stevearc/nvim-typecheck-action@v2
         with:
           path: lua
           libraries: https://github.com/nvim-neotest/neotest https://github.com/mfussenegger/nvim-dap

lua/overseer/binding_util.lua

@@ -3,6 +3,8 @@ local layout = require("overseer.layout")
 local util = require("overseer.util")
 local M = {}
 
+---@diagnostic disable: undefined-field
+
 M.create_plug_bindings = function(bufnr, plug_bindings, ...)
   local args = vim.F.pack_len(...)
   for _, binding in ipairs(plug_bindings) do
@@ -108,8 +110,8 @@ M.show_bindings = function(prefix)
   end
   vim.keymap.set("n", "q", "<cmd>close<CR>", { buffer = bufnr })
   vim.keymap.set("n", "<c-c>", "<cmd>close<CR>", { buffer = bufnr })
-  vim.api.nvim_buf_set_option(bufnr, "modifiable", false)
-  vim.api.nvim_buf_set_option(bufnr, "bufhidden", "wipe")
+  vim.bo[bufnr].modifiable = false
+  vim.bo[bufnr].bufhidden = "wipe"
 
   local width = layout.calculate_width(max_line + 1, { min_width = 20 })
   local height = layout.calculate_height(#lines, { min_height = 10 })
@@ -124,7 +126,7 @@ M.show_bindings = function(prefix)
     zindex = config.help_win.zindex,
   })
   for opt, value in pairs(config.help_win.win_opts or {}) do
-    vim.api.nvim_win_set_option(win, opt, value)
+    vim.wo[win][opt] = value
   end
 end
 

lua/overseer/confirm.lua

@@ -23,10 +23,10 @@ return function(opts, callback)
   end
 
   local bufnr = vim.api.nvim_create_buf(false, true)
-  vim.api.nvim_buf_set_option(bufnr, "buftype", "nofile")
-  vim.api.nvim_buf_set_option(bufnr, "bufhidden", "wipe")
-  vim.api.nvim_buf_set_option(bufnr, "buflisted", false)
-  vim.api.nvim_buf_set_option(bufnr, "swapfile", false)
+  vim.bo[bufnr].buftype = "nofile"
+  vim.bo[bufnr].bufhidden = "wipe"
+  vim.bo[bufnr].buflisted = false
+  vim.bo[bufnr].swapfile = false
   local winid
 
   local function choose(idx)
@@ -143,5 +143,5 @@ return function(opts, callback)
     once = true,
     nested = true,
   })
-  vim.api.nvim_buf_set_option(bufnr, "modifiable", false)
+  vim.bo[bufnr].modifiable = false
 end

lua/overseer/form/init.lua

@@ -97,9 +97,9 @@ function Builder.new(title, schema, params, callback)
   end
 
   local bufnr = vim.api.nvim_create_buf(false, true)
-  vim.api.nvim_buf_set_option(bufnr, "swapfile", false)
-  vim.api.nvim_buf_set_option(bufnr, "bufhidden", "wipe")
-  vim.api.nvim_buf_set_option(bufnr, "buftype", "acwrite")
+  vim.bo[bufnr].swapfile = false
+  vim.bo[bufnr].bufhidden = "wipe"
+  vim.bo[bufnr].buftype = "acwrite"
   vim.api.nvim_buf_set_name(bufnr, "Overseer task builder")
 
   local autocmds = {}
@@ -134,7 +134,7 @@ function Builder.new(title, schema, params, callback)
       end,
     })
   )
-  vim.api.nvim_buf_set_option(bufnr, "filetype", "OverseerForm")
+  vim.bo[bufnr].filetype = "OverseerForm"
 
   builder = setmetatable({
     disable_close_on_leave = false,

lua/overseer/form/utils.lua

@@ -355,7 +355,7 @@ M.open_form_win = function(bufnr, opts)
     })
   )
 
-  vim.api.nvim_buf_set_option(bufnr, "omnifunc", "v:lua.overseer_form_omnifunc")
+  vim.bo[bufnr].omnifunc = "v:lua.overseer_form_omnifunc"
   -- Configure nvim-cmp if installed
   local has_cmp, cmp = pcall(require, "cmp")
   if has_cmp then

lua/overseer/parser/debug.lua

@@ -75,9 +75,9 @@ local function render_parser(input_lnum)
   vim.api.nvim_buf_clear_namespace(bufnr, ns, 0, -1)
   local p, err = load_parser()
   if not p then
-    vim.api.nvim_buf_set_option(bufnr, "modifiable", true)
+    vim.bo[bufnr].modifiable = true
     vim.api.nvim_buf_set_lines(bufnr, 0, -1, true, vim.split(vim.inspect(err), "\n"))
-    vim.api.nvim_buf_set_option(bufnr, "modifiable", false)
+    vim.bo[bufnr].modifiable = false
     return
   end
   p:ingest(vim.api.nvim_buf_get_lines(input_buf, 0, input_lnum or -1, true))
@@ -104,9 +104,9 @@ local function render_parser(input_lnum)
   local results = p:get_result()
   vim.list_extend(lines, vim.split(vim.inspect(results), "\n"))
 
-  vim.api.nvim_buf_set_option(bufnr, "modifiable", true)
+  vim.bo[bufnr].modifiable = true
   vim.api.nvim_buf_set_lines(bufnr, 0, -1, true, lines)
-  vim.api.nvim_buf_set_option(bufnr, "modifiable", false)
+  vim.bo[bufnr].modifiable = false
   util.add_highlights(bufnr, ns, highlights)
 end
 
@@ -147,8 +147,8 @@ local function create_output_buf(bufnr)
     vim.api.nvim_win_set_buf(0, bufnr)
   end
   output_buf = bufnr
-  vim.api.nvim_buf_set_option(bufnr, "bufhidden", "wipe")
-  vim.api.nvim_buf_set_option(bufnr, "modifiable", false)
+  vim.bo[bufnr].bufhidden = "wipe"
+  vim.bo[bufnr].modifiable = false
 end
 
 local function create_input_buf()

lua/overseer/task.lua

@@ -563,7 +563,7 @@ function Task:dispose(force)
   task_list.remove(self)
   if bufnr and vim.api.nvim_buf_is_valid(bufnr) then
     if bufnr_visible then
-      vim.api.nvim_buf_set_option(bufnr, "bufhidden", "wipe")
+      vim.bo[bufnr].bufhidden = "wipe"
     else
       vim.api.nvim_buf_delete(bufnr, { force = true })
     end
@@ -636,7 +636,7 @@ function Task:start()
   self:dispatch("on_start")
   local bufnr = self.strategy:get_bufnr()
   if bufnr then
-    vim.api.nvim_buf_set_option(bufnr, "buflisted", false)
+    vim.bo[bufnr].buflisted = false
   end
 
   util.replace_buffer_in_wins(self.prev_bufnr, bufnr)

lua/overseer/task_list/sidebar.lua

@@ -35,11 +35,11 @@ function Sidebar.new()
   local bufnr = vim.api.nvim_create_buf(false, true)
 
   -- Set buffer options
-  vim.api.nvim_buf_set_option(bufnr, "buftype", "nofile")
-  vim.api.nvim_buf_set_option(bufnr, "bufhidden", "hide")
-  vim.api.nvim_buf_set_option(bufnr, "buflisted", false)
-  vim.api.nvim_buf_set_option(bufnr, "swapfile", false)
-  vim.api.nvim_buf_set_option(bufnr, "modifiable", false)
+  vim.bo[bufnr].buftype = "nofile"
+  vim.bo[bufnr].bufhidden = "hide"
+  vim.bo[bufnr].buflisted = false
+  vim.bo[bufnr].swapfile = false
+  vim.bo[bufnr].modifiable = false
 
   local tl = setmetatable({
     bufnr = bufnr,
@@ -344,10 +344,10 @@ function Sidebar:render(tasks)
       view = vim.fn.winsaveview()
     end)
   end
-  vim.api.nvim_buf_set_option(self.bufnr, "modifiable", true)
+  vim.bo[self.bufnr].modifiable = true
   vim.api.nvim_buf_set_lines(self.bufnr, 0, -1, true, lines)
-  vim.api.nvim_buf_set_option(self.bufnr, "modifiable", false)
-  vim.api.nvim_buf_set_option(self.bufnr, "modified", false)
+  vim.bo[self.bufnr].modifiable = false
+  vim.bo[self.bufnr].modified = false
   util.add_highlights(self.bufnr, ns, highlights)
 
   if prev_first_task_id ~= new_first_task_id then

lua/overseer/util.lua

@@ -78,12 +78,8 @@ local function create_cursormoved_tail_autocmd()
       local lnum = vim.api.nvim_win_get_cursor(0)[1]
       local linecount = vim.api.nvim_buf_line_count(0)
       if lnum == linecount then
-        -- TODO remove after https://github.com/folke/neodev.nvim/pull/163 lands
-        ---@diagnostic disable-next-line: inject-field
         vim.w.overseer_pause_tail_for_buf = nil
       else
-        -- TODO remove after https://github.com/folke/neodev.nvim/pull/163 lands
-        ---@diagnostic disable-next-line: inject-field
         vim.w.overseer_pause_tail_for_buf = args.buf
       end
     end,

lua/overseer/window.lua

@@ -70,8 +70,6 @@ local function create_overseer_window(direction, existing_win)
     util.go_buf_no_au(outbuf)
     set_minimal_win_opts(0)
     util.go_win_no_au(winid)
-    -- TODO remove after https://github.com/folke/neodev.nvim/pull/163 lands
-    ---@diagnostic disable-next-line: inject-field
     vim.w.overseer_output_win = output_win
     watch_for_win_closed()
   end
@@ -97,7 +95,7 @@ local function create_overseer_window(direction, existing_win)
   end
   -- Set the filetype only after we enter the buffer so that FileType autocmds
   -- behave properly
-  vim.api.nvim_buf_set_option(bufnr, "filetype", "OverseerList")
+  vim.bo[bufnr].filetype = "OverseerList"
 
   util.go_win_no_au(my_winid)
   return winid