Skip to content

Commit 866fbb1

Browse files
committed
pin version in testing
span names changed open-telemetry/opentelemetry-python-contrib#1757
1 parent c1131a3 commit 866fbb1

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"coverage",
3939
"pytest",
4040
"opentelemetry-sdk",
41-
"opentelemetry-instrumentation-requests",
41+
"opentelemetry-instrumentation-requests>=0.39b0",
4242
],
4343
"instruments": PACKAGE_INFO["_instruments"],
4444
},

tests/test_http.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ def test_no_match(self, container, web_session, memory_exporter):
8989
spans = memory_exporter.get_finished_spans()
9090
assert len(spans) == 1
9191

92-
assert spans[0].name == "HTTP GET"
92+
assert spans[0].name == "GET /missing"
9393

9494

9595
class TestNoEntrypointFired:
@@ -121,7 +121,7 @@ def test_method_not_found(self, container, web_session, memory_exporter):
121121

122122
span = spans[0]
123123

124-
assert spans[0].name == "HTTP GET"
124+
assert spans[0].name == "GET /missing"
125125

126126
assert not span.status.is_ok
127127
assert span.status.status_code == StatusCode.ERROR
@@ -139,7 +139,7 @@ def test_method_not_allowed(self, container, web_session, memory_exporter):
139139

140140
span = spans[0]
141141

142-
assert spans[0].name == "HTTP POST"
142+
assert spans[0].name == "POST /resource"
143143

144144
assert not span.status.is_ok
145145
assert span.status.status_code == StatusCode.ERROR

0 commit comments

Comments
 (0)