Skip to content

Support validation of custom S3 ca certificates #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
sbernauer opened this issue Jan 19, 2023 · 1 comment
Closed
3 tasks done

Support validation of custom S3 ca certificates #194

sbernauer opened this issue Jan 19, 2023 · 1 comment

Comments

@sbernauer
Copy link
Member

sbernauer commented Jan 19, 2023

Context #187 (comment)

On-prem S3 often use a ca cert from an internal PKI. To be able to talk to on-prem S3 stores we need to implement using ca.crt of SecretClasses to validate S3 certificates.
This is already correctly implemented in Trino, some links are here and here.

IMHO this is a important feature as well as a bug as we don't respect what the user has entered into the S3Connection.

Acceptance criteria:

  • Being able to add ca.cert to the java trust store (as a secret)
  • Having tests in place
  • New functionality is documented
@Maleware Maleware self-assigned this May 9, 2023
@Maleware Maleware moved this from Next to Refinement: In Progress in Stackable Engineering May 9, 2023
@Maleware Maleware moved this from Refinement: In Progress to Refinement Acceptance: Waiting for in Stackable Engineering May 9, 2023
@lfrancke lfrancke moved this from Refinement Acceptance: Waiting for to Development: In Progress in Stackable Engineering May 15, 2023
@adwk67 adwk67 moved this from Development: In Progress to Development: In Review in Stackable Engineering Jun 2, 2023
@adwk67 adwk67 self-assigned this Jun 2, 2023
@adwk67 adwk67 moved this from Development: In Review to Development: In Progress in Stackable Engineering Jun 19, 2023
@bors bors bot closed this as completed in f466bac Jun 20, 2023
@adwk67 adwk67 moved this from Development: In Progress to Development: Done in Stackable Engineering Jun 20, 2023
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Jun 23, 2023
@lfrancke
Copy link
Member

None of the boxes have been ticked. Can you please make sure to update the ticket

@lfrancke lfrancke moved this from Acceptance: In Progress to Done in Stackable Engineering Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants