Skip to content

Commit 91bf0ab

Browse files
committed
fix: Typo in executor cpu limit property (#263)
# Description Introduced in #256
1 parent f744e7b commit 91bf0ab

File tree

4 files changed

+12
-10
lines changed

4 files changed

+12
-10
lines changed

CHANGELOG.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,20 +13,21 @@ All notable changes to this project will be documented in this file.
1313
- Add support for using custom certificates when accessing S3 with TLS ([#247]).
1414
- Use bitnami charts for testing S3 access with TLS ([#247]).
1515
- Set explicit resources on all containers ([#249]).
16-
- Support pod overrides ([#256])
16+
- Support pod overrides ([#256]).
1717

1818
### Changed
1919

2020
- `operator-rs` `0.38.0` -> `0.44.0` ([#235], [#259]).
21-
- Use 0.0.0-dev product images for testing ([#236])
22-
- Use testing-tools 0.2.0 ([#236])
21+
- Use 0.0.0-dev product images for testing ([#236]).
22+
- Use testing-tools 0.2.0 ([#236]).
2323
- Run as root group ([#241]).
24-
- Added kuttl test suites ([#252])
24+
- Added kuttl test suites ([#252]).
2525

2626
### Fixed
2727

2828
- Fix quoting issues when spark config values contain spaces ([#243]).
29-
- Increase the size limit of log volumes (#[259])
29+
- Increase the size limit of log volumes ([#259]).
30+
- Typo in executor cpu limit property ([#263]).
3031

3132
[#235]: https://github.com/stackabletech/spark-k8s-operator/pull/235
3233
[#236]: https://github.com/stackabletech/spark-k8s-operator/pull/236
@@ -38,6 +39,7 @@ All notable changes to this project will be documented in this file.
3839
[#249]: https://github.com/stackabletech/spark-k8s-operator/pull/249
3940
[#256]: https://github.com/stackabletech/spark-k8s-operator/pull/256
4041
[#259]: https://github.com/stackabletech/spark-k8s-operator/pull/259
42+
[#263]: https://github.com/stackabletech/spark-k8s-operator/pull/263
4143

4244
## [23.4.0] - 2023-04-17
4345

rust/crd/src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -813,7 +813,7 @@ fn resources_to_executor_props(
813813
"spark.kubernetes.executor.request.cores".to_string(),
814814
cores.clone(),
815815
);
816-
props.insert("spark.kubernetes.executors.limit.cores".to_string(), cores);
816+
props.insert("spark.kubernetes.executor.limit.cores".to_string(), cores);
817817
}
818818

819819
if let Resources {
@@ -1532,7 +1532,7 @@ spec:
15321532
"512m".to_string(),
15331533
),
15341534
(
1535-
"spark.kubernetes.executors.limit.cores".to_string(),
1535+
"spark.kubernetes.executor.limit.cores".to_string(),
15361536
"2".to_string(),
15371537
),
15381538
]

tests/templates/kuttl/resources/10-assert.yaml.j2

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,10 @@ spec:
3636
resources:
3737
# these resources are set via Spark submit properties like "spark.driver.cores"
3838
limits:
39-
cpu: "1"
39+
cpu: "2"
4040
memory: 1Gi
4141
requests:
42-
cpu: "1"
42+
cpu: "2"
4343
memory: 1Gi
4444
---
4545
apiVersion: v1

tests/templates/kuttl/resources/10-deploy-spark-app.yaml.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ spec:
3131
resources:
3232
cpu:
3333
min: 200m
34-
max: 1000m
34+
max: 1200m
3535
memory:
3636
limit: 1024Mi
3737
executor:

0 commit comments

Comments
 (0)