Fixed group plugin crashing when using hooks

Author: squidfunk

material/plugins/group/plugin.py

@@ -82,11 +82,18 @@ def on_config(self, config):
         # Invoke `on_startup` event for plugins in group
         command = "serve" if self.is_serve else "build"
         for method in option.plugins.events["startup"]:
-            if method.__self__ in self.plugins.values():
+            plugin = self._get_plugin(method)
+
+            # Ensure that we have a method bound to a plugin (and not a hook)
+            if plugin and plugin in self.plugins.values():
                 method(command = command, dirty = self.is_dirty)
 
     # -------------------------------------------------------------------------
 
+    # Retrieve plugin instance for bound method or nothing
+    def _get_plugin(self, method: Callable):
+        return getattr(method, "__self__", None)
+
     # Retrieve priority of plugin method
     def _get_priority(self, method: Callable):
         return getattr(method, "mkdocs_priority", 0)
@@ -117,17 +124,23 @@ def _patch(self, methods: list[Callable], config: MkDocsConfig):
             head = methods[at]
 
             # Skip if the plugin is not part of the group
-            if not head.__self__ in self.plugins.values():
+            plugin = self._get_plugin(head)
+            if not plugin or plugin not in self.plugins.values():
                 continue
 
             # Skip if the previous method has a higher priority than the current
             # one, because we know we can't swap them anyway
             if self._get_priority(tail) > self._get_priority(head):
                 continue
 
+            # Ensure that we have a method bound to a plugin (and not a hook)
+            plugin = self._get_plugin(tail)
+            if not plugin:
+                continue
+
             # Both methods have the same priority, so we check if the ordering
             # of both methods is violated, and if it is, swap them
-            if (position < self._get_position(tail.__self__, config)):
+            if (position < self._get_position(plugin, config)):
                 methods[at], methods[at - 1] = tail, head
 
 # -----------------------------------------------------------------------------

src/plugins/group/plugin.py

@@ -82,11 +82,18 @@ def on_config(self, config):
         # Invoke `on_startup` event for plugins in group
         command = "serve" if self.is_serve else "build"
         for method in option.plugins.events["startup"]:
-            if method.__self__ in self.plugins.values():
+            plugin = self._get_plugin(method)
+
+            # Ensure that we have a method bound to a plugin (and not a hook)
+            if plugin and plugin in self.plugins.values():
                 method(command = command, dirty = self.is_dirty)
 
     # -------------------------------------------------------------------------
 
+    # Retrieve plugin instance for bound method or nothing
+    def _get_plugin(self, method: Callable):
+        return getattr(method, "__self__", None)
+
     # Retrieve priority of plugin method
     def _get_priority(self, method: Callable):
         return getattr(method, "mkdocs_priority", 0)
@@ -117,17 +124,23 @@ def _patch(self, methods: list[Callable], config: MkDocsConfig):
             head = methods[at]
 
             # Skip if the plugin is not part of the group
-            if not head.__self__ in self.plugins.values():
+            plugin = self._get_plugin(head)
+            if not plugin or plugin not in self.plugins.values():
                 continue
 
             # Skip if the previous method has a higher priority than the current
             # one, because we know we can't swap them anyway
             if self._get_priority(tail) > self._get_priority(head):
                 continue
 
+            # Ensure that we have a method bound to a plugin (and not a hook)
+            plugin = self._get_plugin(tail)
+            if not plugin:
+                continue
+
             # Both methods have the same priority, so we check if the ordering
             # of both methods is violated, and if it is, swap them
-            if (position < self._get_position(tail.__self__, config)):
+            if (position < self._get_position(plugin, config)):
                 methods[at], methods[at - 1] = tail, head
 
 # -----------------------------------------------------------------------------