Fixed double-complete errors after upgrading to RxJS 7.3

Author: squidfunk

material/assets/javascripts/bundle.2b46852b.min.js

@@ -223,7 +223,7 @@ <h1>{{ page.title | d(config.site_name, true)}}</h1>
       </script>
     {% endblock %}
     {% block scripts %}
-      <script src="{{ 'assets/javascripts/bundle.2b46852b.min.js' | url }}"></script>
+      <script src="{{ 'assets/javascripts/bundle.806c4996.min.js' | url }}"></script>
       {% for path in config["extra_javascript"] %}
         <script src="{{ path | url }}"></script>
       {% endfor %}

material/assets/javascripts/bundle.806c4996.min.js

@@ -16,5 +16,5 @@
 {% endblock %}
 {% block scripts %}
   {{ super() }}
-  <script src="{{ 'overrides/assets/javascripts/bundle.1d33a92e.min.js' | url }}"></script>
+  <script src="{{ 'overrides/assets/javascripts/bundle.dba5ec94.min.js' | url }}"></script>
 {% endblock %}

material/assets/javascripts/bundle.2b46852b.min.js.map renamed to material/assets/javascripts/bundle.806c4996.min.js.map

@@ -42,7 +42,7 @@
     "fuzzaldrin-plus": "^0.6.0",
     "lunr": "^2.3.9",
     "lunr-languages": "^1.8.0",
-    "rxjs": "7.2.0"
+    "rxjs": "^7.3.0"
   },
   "devDependencies": {
     "@fortawesome/fontawesome-free": "^5.15.3",

material/base.html

@@ -31,7 +31,6 @@ import {
 } from "rxjs"
 import {
   distinctUntilKeyChanged,
-  finalize,
   map,
   switchMap,
   tap,
@@ -177,7 +176,6 @@ export function mountCodeBlock(
   return watchCodeBlock(el, options)
     .pipe(
       tap(internal$),
-      finalize(() => internal$.complete()),
       map(state => ({ ref: el, ...state }))
     )
 }

material/overrides/assets/javascripts/bundle.1d33a92e.min.js

@@ -23,7 +23,6 @@
 import { Observable, Subject } from "rxjs"
 import {
   filter,
-  finalize,
   map,
   mapTo,
   mergeWith,
@@ -109,7 +108,6 @@ export function mountDetails(
   return watchDetails(el, options)
     .pipe(
       tap(internal$),
-      finalize(() => internal$.complete()),
       mapTo({ ref: el })
     )
 }

material/overrides/assets/javascripts/bundle.dba5ec94.min.js

@@ -29,7 +29,6 @@ import {
 } from "rxjs"
 import {
   delay,
-  finalize,
   map,
   observeOn,
   switchMap,
@@ -133,7 +132,6 @@ export function mountDialog(
   return watchDialog(el, options)
     .pipe(
       tap(internal$),
-      finalize(() => internal$.complete()),
       map(state => ({ ref: el, ...state }))
     )
 }

material/overrides/assets/javascripts/bundle.1d33a92e.min.js.map renamed to material/overrides/assets/javascripts/bundle.dba5ec94.min.js.map

@@ -28,7 +28,6 @@ import {
 } from "rxjs"
 import {
   distinctUntilKeyChanged,
-  finalize,
   map,
   observeOn,
   tap
@@ -141,7 +140,6 @@ export function mountHeaderTitle(
   return watchHeaderTitle(headline, options)
     .pipe(
       tap(internal$),
-      finalize(() => internal$.complete()),
       map(state => ({ ref: el, ...state }))
     )
 }

material/overrides/main.html

@@ -27,7 +27,6 @@ import {
   of
 } from "rxjs"
 import {
-  finalize,
   map,
   mapTo,
   mergeMap,
@@ -142,7 +141,6 @@ export function mountPalette(
   return watchPalette(inputs)
     .pipe(
       tap(internal$),
-      finalize(() => internal$.complete()),
       map(state => ({ ref: el, ...state }))
     )
 }

package-lock.json

@@ -32,7 +32,6 @@ import {
   distinctUntilChanged,
   distinctUntilKeyChanged,
   filter,
-  finalize,
   map,
   take,
   takeLast,
@@ -174,7 +173,6 @@ export function mountSearchQuery(
   return watchSearchQuery(el, { tx$, rx$ })
     .pipe(
       tap(internal$),
-      finalize(() => internal$.complete()),
       map(state => ({ ref: el, ...state }))
     )
 }

package.json

@@ -30,7 +30,6 @@ import {
 import {
   bufferCount,
   filter,
-  finalize,
   map,
   observeOn,
   switchMap,
@@ -154,7 +153,6 @@ export function mountSearchResult(
   return result$
     .pipe(
       tap(internal$),
-      finalize(() => internal$.complete()),
       map(state => ({ ref: el, ...state }))
     )
 }

src/assets/javascripts/components/content/code/index.ts

@@ -25,11 +25,7 @@ import {
   Subject,
   fromEvent
 } from "rxjs"
-import {
-  finalize,
-  map,
-  tap
-} from "rxjs/operators"
+import { map, tap } from "rxjs/operators"
 
 import { getLocation } from "~/browser"
 
@@ -117,7 +113,6 @@ export function mountSearchShare(
   return watchSearchShare(el, options)
     .pipe(
       tap(internal$),
-      finalize(() => internal$.complete()),
       map(state => ({ ref: el, ...state }))
     )
 }

src/assets/javascripts/components/content/details/index.ts

@@ -30,7 +30,6 @@ import {
   combineLatestWith,
   distinctUntilChanged,
   filter,
-  finalize,
   map,
   observeOn,
   tap
@@ -146,7 +145,6 @@ export function mountSearchSuggest(
   return result$
     .pipe(
       tap(internal$),
-      finalize(() => internal$.complete()),
       map(() => ({ ref: el }))
     )
 }

src/assets/javascripts/components/dialog/index.ts

@@ -28,7 +28,6 @@ import {
 } from "rxjs"
 import {
   distinctUntilChanged,
-  finalize,
   map,
   observeOn,
   tap,
@@ -159,7 +158,6 @@ export function mountSidebar(
   return watchSidebar(el, options)
     .pipe(
       tap(internal$),
-      finalize(() => internal$.complete()),
       map(state => ({ ref: el, ...state }))
     )
 }

src/assets/javascripts/components/header/title/index.ts

@@ -24,7 +24,6 @@ import { NEVER, Observable, Subject, defer, of } from "rxjs"
 import {
   catchError,
   filter,
-  finalize,
   map,
   shareReplay,
   tap
@@ -119,7 +118,6 @@ export function mountSource(
   return watchSource(el)
     .pipe(
       tap(internal$),
-      finalize(() => internal$.complete()),
       map(state => ({ ref: el, ...state }))
     )
 }

src/assets/javascripts/components/palette/index.ts

@@ -23,7 +23,6 @@
 import { Observable, Subject, animationFrameScheduler } from "rxjs"
 import {
   distinctUntilKeyChanged,
-  finalize,
   map,
   observeOn,
   switchMap,
@@ -137,7 +136,6 @@ export function mountTabs(
   return watchTabs(el, options)
     .pipe(
       tap(internal$),
-      finalize(() => internal$.complete()),
       map(state => ({ ref: el, ...state }))
     )
 }

src/assets/javascripts/components/search/query/index.ts

@@ -30,7 +30,6 @@ import {
   bufferCount,
   distinctUntilChanged,
   distinctUntilKeyChanged,
-  finalize,
   map,
   observeOn,
   scan,
@@ -269,7 +268,6 @@ export function mountTableOfContents(
   return watchTableOfContents(anchors, options)
     .pipe(
       tap(internal$),
-      finalize(() => internal$.complete()),
       map(state => ({ ref: el, ...state }))
     )
 }

src/assets/javascripts/components/search/result/index.ts

@@ -30,7 +30,6 @@ import {
   bufferCount,
   distinctUntilChanged,
   distinctUntilKeyChanged,
-  finalize,
   map,
   observeOn,
   tap,
@@ -172,7 +171,6 @@ export function mountBackToTop(
   return watchBackToTop(el, { viewport$, header$, main$ })
     .pipe(
       tap(internal$),
-      finalize(() => internal$.complete()),
       map(state => ({ ref: el, ...state }))
     )
 }

src/assets/javascripts/components/search/share/index.ts

@@ -33,7 +33,6 @@ import {
   bufferCount,
   distinctUntilKeyChanged,
   filter,
-  finalize,
   map,
   observeOn,
   switchMap,
@@ -193,7 +192,6 @@ export function mountIconSearchResult(
   return watchIconSearchResult(el, { query$, index$ })
     .pipe(
       tap(internal$),
-      finalize(() => internal$.complete()),
       map(state => ({ ref: el, ...state }))
     )
 }