Skip to content

Commit a200e7d

Browse files
committed
Fixed accessibility issue with search result list
1 parent 89a77c5 commit a200e7d

File tree

6 files changed

+18
-11
lines changed

6 files changed

+18
-11
lines changed

material/assets/javascripts/bundle.ba449ae6.min.js renamed to material/assets/javascripts/bundle.51d95adb.min.js

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

material/assets/javascripts/bundle.ba449ae6.min.js.map renamed to material/assets/javascripts/bundle.51d95adb.min.js.map

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

material/base.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@
240240
</script>
241241
{% endblock %}
242242
{% block scripts %}
243-
<script src="{{ 'assets/javascripts/bundle.ba449ae6.min.js' | url }}"></script>
243+
<script src="{{ 'assets/javascripts/bundle.51d95adb.min.js' | url }}"></script>
244244
{% for path in config.extra_javascript %}
245245
<script src="{{ path | url }}"></script>
246246
{% endfor %}

material/partials/search.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
<div class="md-search-result__meta">
3131
{{ lang.t("search.result.initializer") }}
3232
</div>
33-
<ol class="md-search-result__list"></ol>
33+
<ol class="md-search-result__list" role="presentation"></ol>
3434
</div>
3535
</div>
3636
</div>

src/assets/javascripts/components/search/result/index.ts

+8-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ import { translation } from "~/_"
4646
import {
4747
getElement,
4848
getOptionalElement,
49-
watchElementBoundary
49+
watchElementBoundary,
50+
watchToggle
5051
} from "~/browser"
5152
import {
5253
SearchMessage,
@@ -103,6 +104,12 @@ export function mountSearchResult(
103104
const meta = getElement(":scope > :first-child", el)
104105
const list = getElement(":scope > :last-child", el)
105106

107+
/* Reveal to accessibility tree – see https://bit.ly/3iAA7t8 */
108+
watchToggle("search")
109+
.subscribe(active => list.setAttribute(
110+
"role", active ? "list" : "presentation"
111+
))
112+
106113
/* Update search result metadata */
107114
push$
108115
.pipe(

src/partials/search.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@
9797
<div class="md-search-result__meta">
9898
{{ lang.t("search.result.initializer") }}
9999
</div>
100-
<ol class="md-search-result__list"></ol>
100+
<ol class="md-search-result__list" role="presentation"></ol>
101101
</div>
102102
</div>
103103
</div>

0 commit comments

Comments
 (0)