Skip to content

Commit a06cf10

Browse files
committed
Fixed RXSS vulnerability in search results
1 parent 89c1d1c commit a06cf10

File tree

5 files changed

+36
-35
lines changed

5 files changed

+36
-35
lines changed

material/templates/assets/javascripts/bundle.20f8b5b3.min.js

-29
This file was deleted.

material/templates/assets/javascripts/bundle.471ce7a9.min.js

+29
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

material/templates/assets/javascripts/bundle.20f8b5b3.min.js.map renamed to material/templates/assets/javascripts/bundle.471ce7a9.min.js.map

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

material/templates/base.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@
249249
</script>
250250
{% endblock %}
251251
{% block scripts %}
252-
<script src="{{ 'assets/javascripts/bundle.20f8b5b3.min.js' | url }}"></script>
252+
<script src="{{ 'assets/javascripts/bundle.471ce7a9.min.js' | url }}"></script>
253253
{% for script in config.extra_javascript %}
254254
{{ script | script_tag }}
255255
{% endfor %}

src/templates/assets/javascripts/templates/search/index.tsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
* IN THE SOFTWARE.
2121
*/
2222

23+
import escapeHTML from "escape-html"
2324
import { ComponentChild } from "preact"
2425

2526
import { configuration, feature, translation } from "~/_"
@@ -60,7 +61,7 @@ function renderSearchDocument(
6061
const missing = Object.keys(document.terms)
6162
.filter(key => !document.terms[key])
6263
.reduce<ComponentChild[]>((list, key) => [
63-
...list, <del>{key}</del>, " "
64+
...list, <del>{escapeHTML(key)}</del>, " "
6465
], [])
6566
.slice(0, -1)
6667

0 commit comments

Comments
 (0)