Skip to content

Commit 8beda2b

Browse files
committed
Fixed handling of 4xx status codes when using instant loading
1 parent 684acdc commit 8beda2b

File tree

14 files changed

+81
-63
lines changed

14 files changed

+81
-63
lines changed

material/assets/javascripts/bundle.c2e1ee47.min.js

+29
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

material/assets/javascripts/bundle.ed9748b7.min.js.map renamed to material/assets/javascripts/bundle.c2e1ee47.min.js.map

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

material/assets/javascripts/bundle.ed9748b7.min.js

-29
This file was deleted.

material/base.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@
214214
</script>
215215
{% endblock %}
216216
{% block scripts %}
217-
<script src="{{ 'assets/javascripts/bundle.ed9748b7.min.js' | url }}"></script>
217+
<script src="{{ 'assets/javascripts/bundle.c2e1ee47.min.js' | url }}"></script>
218218
{% for path in config["extra_javascript"] %}
219219
<script src="{{ path | url }}"></script>
220220
{% endfor %}

material/overrides/assets/javascripts/bundle.2bc01bfd.min.js

+18
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

material/overrides/assets/javascripts/bundle.2bc01bfd.min.js.map

+8
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

material/overrides/assets/javascripts/bundle.641d98f2.min.js

-18
This file was deleted.

material/overrides/assets/javascripts/bundle.641d98f2.min.js.map

-8
This file was deleted.

material/overrides/main.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@
1919
{% endblock %}
2020
{% block scripts %}
2121
{{ super() }}
22-
<script src="{{ 'overrides/assets/javascripts/bundle.641d98f2.min.js' | url }}"></script>
22+
<script src="{{ 'overrides/assets/javascripts/bundle.2bc01bfd.min.js' | url }}"></script>
2323
{% endblock %}

src/assets/javascripts/browser/request/index.ts

+8-4
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,12 @@ import {
2424
EMPTY,
2525
Observable,
2626
catchError,
27-
filter,
2827
from,
2928
map,
29+
of,
3030
shareReplay,
31-
switchMap
31+
switchMap,
32+
throwError
3233
} from "rxjs"
3334

3435
/* ----------------------------------------------------------------------------
@@ -51,8 +52,11 @@ export function request(
5152
): Observable<Response> {
5253
return from(fetch(`${url}`, options))
5354
.pipe(
54-
filter(res => res.status === 200),
55-
catchError(() => EMPTY)
55+
catchError(() => EMPTY),
56+
switchMap(res => res.status !== 200
57+
? throwError(() => new Error(res.statusText))
58+
: of(res)
59+
)
5660
)
5761
}
5862

src/assets/javascripts/components/source/facts/github/index.ts

+4
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@
2222

2323
import { Repo, User } from "github-types"
2424
import {
25+
EMPTY,
2526
Observable,
27+
catchError,
2628
defaultIfEmpty,
2729
map,
2830
zip
@@ -65,6 +67,7 @@ export function fetchSourceFactsFromGitHub(
6567
/* Fetch version */
6668
requestJSON<Release>(`${url}/releases/latest`)
6769
.pipe(
70+
catchError(() => EMPTY), // @todo refactor instant loading
6871
map(release => ({
6972
version: release.tag_name
7073
})),
@@ -74,6 +77,7 @@ export function fetchSourceFactsFromGitHub(
7477
/* Fetch stars and forks */
7578
requestJSON<Repo>(url)
7679
.pipe(
80+
catchError(() => EMPTY), // @todo refactor instant loading
7781
map(info => ({
7882
stars: info.stargazers_count,
7983
forks: info.forks_count

src/assets/javascripts/components/source/facts/gitlab/index.ts

+3
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@
2222

2323
import { ProjectSchema } from "gitlab"
2424
import {
25+
EMPTY,
2526
Observable,
27+
catchError,
2628
defaultIfEmpty,
2729
map
2830
} from "rxjs"
@@ -49,6 +51,7 @@ export function fetchSourceFactsFromGitLab(
4951
const url = `https://${base}/api/v4/projects/${encodeURIComponent(project)}`
5052
return requestJSON<ProjectSchema>(url)
5153
.pipe(
54+
catchError(() => EMPTY), // @todo refactor instant loading
5255
map(({ star_count, forks_count }) => ({
5356
stars: star_count,
5457
forks: forks_count

src/assets/javascripts/integrations/sitemap/index.ts

+3
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,9 @@
2121
*/
2222

2323
import {
24+
EMPTY,
2425
Observable,
26+
catchError,
2527
defaultIfEmpty,
2628
map,
2729
of,
@@ -97,6 +99,7 @@ export function fetchSitemap(base?: URL): Observable<Sitemap> {
9799
map(sitemap => preprocess(getElements("loc", sitemap)
98100
.map(node => node.textContent!)
99101
)),
102+
catchError(() => EMPTY), // @todo refactor instant loading
100103
defaultIfEmpty([]),
101104
tap(sitemap => __md_set("__sitemap", sitemap, sessionStorage, base))
102105
)

src/assets/javascripts/integrations/version/index.ts

+4
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import {
2424
EMPTY,
2525
Subject,
26+
catchError,
2627
combineLatest,
2728
filter,
2829
fromEvent,
@@ -73,6 +74,9 @@ export function setupVersionSelector(
7374
const versions$ = requestJSON<Version[]>(
7475
new URL("../versions.json", config.base)
7576
)
77+
.pipe(
78+
catchError(() => EMPTY) // @todo refactor instant loading
79+
)
7680

7781
/* Determine current version */
7882
const current$ = versions$

0 commit comments

Comments
 (0)