Skip to content

Commit 8779d78

Browse files
committed
Fixed race condition ehen displaying search result metadata
1 parent 905c8b7 commit 8779d78

File tree

6 files changed

+17
-22
lines changed

6 files changed

+17
-22
lines changed

material/assets/javascripts/bundle.39a44d95.min.js renamed to material/assets/javascripts/bundle.bc35569b.min.js

+6-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

material/assets/javascripts/bundle.39a44d95.min.js.map renamed to material/assets/javascripts/bundle.bc35569b.min.js.map

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

material/base.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ <h1>{{ page.title | d(config.site_name, true)}}</h1>
225225
</script>
226226
{% endblock %}
227227
{% block scripts %}
228-
<script src="{{ 'assets/javascripts/bundle.39a44d95.min.js' | url }}"></script>
228+
<script src="{{ 'assets/javascripts/bundle.bc35569b.min.js' | url }}"></script>
229229
{% for path in config["extra_javascript"] %}
230230
<script src="{{ path | url }}"></script>
231231
{% endfor %}

src/assets/javascripts/components/search/_/index.ts

+2-6
Original file line numberDiff line numberDiff line change
@@ -107,12 +107,8 @@ export function mountSearch(
107107
tx$
108108
.pipe(
109109
filter(isSearchQueryMessage),
110-
sample(rx$
111-
.pipe(
112-
filter(isSearchReadyMessage),
113-
take(1)
114-
)
115-
)
110+
sample(rx$.pipe(filter(isSearchReadyMessage))),
111+
take(1)
116112
)
117113
.subscribe(tx$.next.bind(tx$))
118114

src/assets/javascripts/components/search/result/index.ts

+4-5
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ import {
3333
finalize,
3434
map,
3535
observeOn,
36+
skipUntil,
3637
switchMap,
3738
take,
3839
tap,
@@ -102,20 +103,18 @@ export function mountSearchResult(
102103
const list = getElementOrThrow(":scope > :last-child", el)
103104

104105
/* Update search result metadata when ready */
105-
rx$
106+
const ready$ = rx$
106107
.pipe(
107108
filter(isSearchReadyMessage),
108109
take(1)
109110
)
110-
.subscribe(() => {
111-
resetSearchResultMeta(meta)
112-
})
113111

114112
/* Update search result metadata */
115113
internal$
116114
.pipe(
117115
observeOn(animationFrameScheduler),
118-
withLatestFrom(query$)
116+
withLatestFrom(query$),
117+
skipUntil(ready$)
119118
)
120119
.subscribe(([{ items }, { value }]) => {
121120
if (value)

src/assets/javascripts/integrations/search/worker/_/index.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -127,10 +127,10 @@ export function setupSearchWorker(
127127
/* Set up search index */
128128
from(index)
129129
.pipe(
130-
map<SearchIndex, SearchSetupMessage>(data => ({
130+
map(data => ({
131131
type: SearchMessageType.SETUP,
132132
data: setupSearchIndex(data)
133-
}))
133+
} as SearchSetupMessage))
134134
)
135135
.subscribe(tx$.next.bind(tx$))
136136

0 commit comments

Comments
 (0)