Skip to content

Commit 6744eb6

Browse files
committed
Fixed missing escaping of HTML in search highlighting
1 parent fc9cfaa commit 6744eb6

File tree

6 files changed

+5
-94
lines changed

6 files changed

+5
-94
lines changed

material/assets/javascripts/bundle.716f8af4.min.js

-29
This file was deleted.

material/assets/javascripts/bundle.716f8af4.min.js.map

-7
This file was deleted.

material/assets/javascripts/workers/search.53c85856.min.js

-48
This file was deleted.

material/assets/javascripts/workers/search.53c85856.min.js.map

-7
This file was deleted.

material/base.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ <h1>{{ page.title | d(config.site_name, true)}}</h1>
196196
"base": base_url,
197197
"features": features,
198198
"translations": {},
199-
"search": "assets/javascripts/workers/search.53c85856.min.js" | url,
199+
"search": "assets/javascripts/workers/search.709b4209.min.js" | url,
200200
"version": config.extra.version or None
201201
} -%}
202202
{%- set translations = app.translations -%}
@@ -223,7 +223,7 @@ <h1>{{ page.title | d(config.site_name, true)}}</h1>
223223
</script>
224224
{% endblock %}
225225
{% block scripts %}
226-
<script src="{{ 'assets/javascripts/bundle.716f8af4.min.js' | url }}"></script>
226+
<script src="{{ 'assets/javascripts/bundle.2b46852b.min.js' | url }}"></script>
227227
{% for path in config["extra_javascript"] %}
228228
<script src="{{ path | url }}"></script>
229229
{% endfor %}

src/assets/javascripts/integrations/search/highlighter/index.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
* IN THE SOFTWARE.
2121
*/
2222

23+
import escapeHTML from "escape-html"
24+
2325
import { SearchIndexConfig } from "../_"
2426

2527
/* ----------------------------------------------------------------------------
@@ -77,7 +79,7 @@ export function setupSearchHighlighter(
7779
})`, "img")
7880

7981
/* Highlight string value */
80-
return value => value
82+
return value => escapeHTML(value)
8183
.replace(match, highlight)
8284
.replace(/<\/mark>(\s+)<mark[^>]*>/img, "$1")
8385
}

0 commit comments

Comments
 (0)