Skip to content

Commit 6dacff2

Browse files
examples: Add missing Close calls (#3828)
* examples: Add missing Close calls * Update db_test.go --------- Co-authored-by: Kyle Gray <[email protected]>
1 parent 17336cc commit 6dacff2

File tree

4 files changed

+7
-0
lines changed

4 files changed

+7
-0
lines changed

examples/authors/sqlite/db_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import (
1212

1313
func TestAuthors(t *testing.T) {
1414
sdb, cleanup := sqltest.SQLite(t, []string{"schema.sql"})
15+
defer sdb.Close()
1516
defer cleanup()
1617

1718
ctx := context.Background()

examples/booktest/sqlite/db_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ const (
1818

1919
func TestBooks(t *testing.T) {
2020
db, cleanup := sqltest.SQLite(t, []string{"schema.sql"})
21+
defer db.Close()
2122
defer cleanup()
2223

2324
ctx := context.Background()

examples/ondeck/sqlite/db_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,7 @@ func TestPrepared(t *testing.T) {
149149
t.Parallel()
150150

151151
sdb, cleanup := sqltest.SQLite(t, []string{"schema"})
152+
defer sdb.Close()
152153
defer cleanup()
153154

154155
q, err := Prepare(context.Background(), sdb)
@@ -163,6 +164,7 @@ func TestQueries(t *testing.T) {
163164
t.Parallel()
164165

165166
sdb, cleanup := sqltest.SQLite(t, []string{"schema"})
167+
defer sdb.Close()
166168
defer cleanup()
167169

168170
runOnDeckQueries(t, New(sdb))

internal/sqltest/sqlite.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ func SQLite(t *testing.T, migrations []string) (*sql.DB, func()) {
1616
if err != nil {
1717
t.Fatal(err)
1818
}
19+
if err := source.Close(); err != nil {
20+
t.Fatal(err)
21+
}
1922
return CreateSQLiteDatabase(t, source.Name(), migrations)
2023
}
2124

0 commit comments

Comments
 (0)