Skip to content

Commit 4e70f83

Browse files
committed
ondeck: tests will still fail due to count(*)
1 parent b8ae839 commit 4e70f83

File tree

4 files changed

+16
-10
lines changed

4 files changed

+16
-10
lines changed

examples/ondeck/mysql/db_test.go

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,9 @@ func runOnDeckQueries(t *testing.T, q *Queries) {
7474
t.Error(err)
7575
}
7676
if diff := cmp.Diff(actual, []VenueCountByCityRow{
77-
{city.Slug, 1},
77+
{city.Slug, int64(1)},
7878
}); diff != "" {
79-
t.Errorf("venue county mismatch:\n%s", diff)
79+
t.Errorf("venue count mismatch:\n%s", diff)
8080
}
8181
}
8282

@@ -111,14 +111,19 @@ func runOnDeckQueries(t *testing.T, q *Queries) {
111111
}
112112

113113
{
114-
id, err := q.UpdateVenueName(ctx, UpdateVenueNameParams{
114+
expected := "Fillmore"
115+
err := q.UpdateVenueName(ctx, UpdateVenueNameParams{
115116
Slug: venue.Slug,
116-
Name: "Fillmore",
117+
Name: expected,
117118
})
118119
if err != nil {
119120
t.Error(err)
120121
}
121-
if diff := cmp.Diff(id, venue.ID); diff != "" {
122+
fresh, err := q.GetVenue(ctx, GetVenueParams{
123+
Slug: venue.Slug,
124+
City: city.Slug,
125+
})
126+
if diff := cmp.Diff(expected, fresh.Slug); diff != "" {
122127
t.Errorf("update venue mismatch:\n%s", diff)
123128
}
124129
}

examples/ondeck/mysql/querier.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/ondeck/mysql/query/venue.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ INSERT INTO venue (
3434
?
3535
);
3636

37-
/* name: UpdateVenueName :execresult */
37+
/* name: UpdateVenueName :exec */
3838
UPDATE venue
3939
SET name = ?
4040
WHERE slug = ?;

examples/ondeck/mysql/venue.sql.go

Lines changed: 4 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)