Skip to content

Springdoc should not use LocalVariableTableParameterNameDiscoverer #2078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rasifix opened this issue Feb 16, 2023 · 6 comments
Closed

Springdoc should not use LocalVariableTableParameterNameDiscoverer #2078

rasifix opened this issue Feb 16, 2023 · 6 comments
Labels
duplicate This issue or pull request already exists

Comments

@rasifix
Copy link

rasifix commented Feb 16, 2023

Springdoc v2 still depends on deprecated LocalVariableTableParameterNameDiscoverer. As a result, Spring Boot 3.x applications log the following:

Using deprecated '-debug' fallback for parameter name resolution. Compile the affected code with '-parameters' instead ...

Springdoc should use the DefaultParameterNameDiscoverer instead.

I'll write a pull request if you agree that this is something that should be fixed in the way I have described it above.

@bnasslahsen
Copy link
Collaborator

see #2028

@bnasslahsen bnasslahsen added the duplicate This issue or pull request already exists label Feb 21, 2023
@rasifix
Copy link
Author

rasifix commented Feb 21, 2023

can you show me the commit where you have dropped usage of LocalVariableTableParameterNameDiscoverer. I still see it used on master as well as 2.x branch, which will still produce the warning in the log.

@bnasslahsen
Copy link
Collaborator

@rasifix,

which version are you using ?

@rasifix
Copy link
Author

rasifix commented Feb 21, 2023

@bnasslahsen - I must have been fooled by the Github search. The code on 2.x branch looks better. I am using 2.0.2 at the moment and will wait for 2.0.3, which contains the fix (?). If it won't work I'll report back.

@bnasslahsen
Copy link
Collaborator

bnasslahsen commented Feb 21, 2023

2.0.2 already ships the fix for not relying on LocalVariableTableParameterNameDiscoverer
So you should not already be having any warnings with that version

2.0.3 will ntegrate few ajustements

@rasifix
Copy link
Author

rasifix commented Feb 22, 2023

oh, perfect. I have just validated and yes, 2.0.2 does no longer produce the warnings. I guess I saw the warnings on a version of the software still running 2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants