Rename name to provider

- Align naming in CommandAvailability
- Relates #663

Author: jvalkeal

spring-shell-core/src/main/java/org/springframework/shell/command/annotation/CommandAvailability.java

@@ -34,9 +34,9 @@
 public @interface CommandAvailability {
 
 	/**
-	 * Names of supplier beans for {@link Availability}.
+	 * Names of provider beans for {@link Availability}.
 	 *
 	 * @return names of supplier beans
 	 */
-	String[] name() default {};
+	String[] provider() default {};
 }

spring-shell-core/src/main/java/org/springframework/shell/command/annotation/support/CommandRegistrationFactoryBean.java

@@ -39,8 +39,6 @@
 import org.springframework.messaging.handler.invocation.InvocableHandlerMethod;
 import org.springframework.shell.Availability;
 import org.springframework.shell.AvailabilityProvider;
-import org.springframework.shell.CompletionContext;
-import org.springframework.shell.CompletionProposal;
 import org.springframework.shell.Utils;
 import org.springframework.shell.command.CommandExceptionResolver;
 import org.springframework.shell.command.CommandHandlingResult;
@@ -55,7 +53,6 @@
 import org.springframework.shell.command.annotation.OptionValues;
 import org.springframework.shell.command.invocation.InvocableShellMethod;
 import org.springframework.shell.completion.CompletionProvider;
-import org.springframework.shell.completion.CompletionResolver;
 import org.springframework.shell.context.InteractionMode;
 import org.springframework.util.ClassUtils;
 import org.springframework.util.ObjectUtils;
@@ -172,7 +169,7 @@ private CommandRegistration buildRegistration() {
 		MergedAnnotation<CommandAvailability> caAnn = MergedAnnotations.from(method, SearchStrategy.TYPE_HIERARCHY)
 				.get(CommandAvailability.class);
 		if (caAnn.isPresent()) {
-			String[] refs = caAnn.getStringArray("name");
+			String[] refs = caAnn.getStringArray("provider");
 			List<AvailabilityProvider> avails = Stream.of(refs)
 				.map(r -> {
 					return this.applicationContext.getBean(r, AvailabilityProvider.class);

spring-shell-core/src/test/java/org/springframework/shell/command/annotation/support/CommandRegistrationFactoryBeanTests.java

@@ -138,7 +138,7 @@ void setsAvailabilitySupplier() {
 	private static class AvailabilityIndicator {
 
 		@Command
-		@CommandAvailability(name = "testAvailability")
+		@CommandAvailability(provider = "testAvailability")
 		void command1() {
 		}
 

spring-shell-samples/src/main/java/org/springframework/shell/samples/e2e/AvailabilityCommands.java

@@ -71,7 +71,7 @@ public Availability testAvailability3LegacyAnnotationAvailability3() {
 	public static class Annotation extends BaseE2ECommands {
 
 		@Command(command = "availability-1")
-		@CommandAvailability(name = "testAvailability1AnnotationAvailability")
+		@CommandAvailability(provider = "testAvailability1AnnotationAvailability")
 		public String testAvailability1Annotation(
 		) {
 			return "Hello";