Deserialize details field in UsernamePasswordAuthenticationToken

buzzerrookie · eleftherias · commit 156fc294bf42 · 2019-12-18T17:35:51.000+01:00
Before this commit, the details field was set to a JsonNode, but now it is deserialized correctly. Fixes gh-7482
diff --git a/core/src/main/java/org/springframework/security/jackson2/UsernamePasswordAuthenticationTokenDeserializer.java b/core/src/main/java/org/springframework/security/jackson2/UsernamePasswordAuthenticationTokenDeserializer.java
@@ -87,7 +87,8 @@ public UsernamePasswordAuthenticationToken deserialize(JsonParser jp, Deserializ
 		if (detailsNode.isNull() || detailsNode.isMissingNode()) {
 			token.setDetails(null);
 		} else {
-			token.setDetails(detailsNode);
+			Object details = mapper.readValue(detailsNode.toString(), new TypeReference<Object>() {});
+			token.setDetails(details);
 		}
 		return token;
 	}

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,8 @@ public UsernamePasswordAuthenticationToken deserialize(JsonParser jp, Deserializ`
`87`	`87`	`if (detailsNode.isNull() \|\| detailsNode.isMissingNode()) {`
`88`	`88`	`token.setDetails(null);`
`89`	`89`	`} else {`
`90`		`- token.setDetails(detailsNode);`
	`90`	`+ Object details = mapper.readValue(detailsNode.toString(), new TypeReference<Object>() {});`
	`91`	`+ token.setDetails(details);`
`91`	`92`	`}`
`92`	`93`	`return token;`
`93`	`94`	`}`